[open-ils-commits] [GIT] Evergreen ILS branch master updated. 4a34d78093052fde921d5c73ba96673515441b8b

Evergreen Git git at git.evergreen-ils.org
Sat Mar 10 13:05:53 EST 2012


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  4a34d78093052fde921d5c73ba96673515441b8b (commit)
      from  a8076f5eefa9eec90a423ab85665659eb78a2e36 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 4a34d78093052fde921d5c73ba96673515441b8b
Author: Dan Scott <dscott at laurentian.ca>
Date:   Sat Mar 10 12:36:08 2012 -0500

    TPAC: Teach mkurl() to discard POST params
    
    Unless we explicitly ask for POST params with the "params" argument to
    mkurl(), prevent them from propagating. (Can't think of situations when
    we would want to propagate a POST param, but we err on the side of
    flexibility so...)
    
    Thanks to Thomas Berezansky for suggesting the CGI url_param() method of
    filtering POST params.
    
    Signed-off-by: Dan Scott <dscott at laurentian.ca>
    Signed-off-by: Thomas Berezansky <tsbere at mvlc.org>

diff --git a/Open-ILS/src/templates/opac/parts/header.tt2 b/Open-ILS/src/templates/opac/parts/header.tt2
index 30dbd6d..5db8139 100644
--- a/Open-ILS/src/templates/opac/parts/header.tt2
+++ b/Open-ILS/src/templates/opac/parts/header.tt2
@@ -57,6 +57,11 @@
         FOR p IN cgi.param;
             val = cgi.param(p);
             IF val == ''; cgi.delete(p); END;
+
+            # Delete POST vars unless we asked for them
+            UNLESS CGI.url_param(p) OR params.defined(p);
+                cgi.delete(p);
+            END;
         END;
 
         IF page;

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/src/templates/opac/parts/header.tt2 |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)


hooks/post-receive
-- 
Evergreen ILS


More information about the open-ils-commits mailing list