[open-ils-commits] [GIT] Evergreen ILS branch master updated. 45be2fa7b6df7ef2708ff55376fc074f7609e99f

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  45be2fa7b6df7ef2708ff55376fc074f7609e99f (commit)
      from  dad78e0222d35454ae0b2e38e855b1ab49c1150b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 45be2fa7b6df7ef2708ff55376fc074f7609e99f
Author: Lebbeous Fogle-Weekley <lebbeous at esilibrary.com>
Date:   Fri Feb 24 14:56:18 2012 -0500

    Avoid JSPAC hold placement interface problems when no holdable copies
    
    This addresses a bug brought to my attention by John Jones.
    
    When you're trying to place certain holds (at least title level holds) on
    records for which there are no holdable formats (no descriptors as returned by
    open-ils.search.metabib.record_to_descriptors), then
    holdArgs.recordDescriptors in holds.js can be an empty array.  There is
    a line of code that assumes this will never happen.
    
    The end user-visible result of the javascript failing here is an alert()
    dialog about phone number format, but this is a red herring.  That only
    happens because the problem code is in one big function that has too
    many responsibilites.
    
    Signed-off-by: Lebbeous Fogle-Weekley <lebbeous at esilibrary.com>
    Signed-off-by: Michael Peters <mrpeters at library.in.gov>
    Signed-off-by: Mike Rylander <mrylander at gmail.com>

diff --git a/Open-ILS/web/opac/skin/default/js/holds.js b/Open-ILS/web/opac/skin/default/js/holds.js
index df7bef4..15e7bc2 100644
--- a/Open-ILS/web/opac/skin/default/js/holds.js
+++ b/Open-ILS/web/opac/skin/default/js/holds.js
@@ -551,7 +551,7 @@ function __holdsDrawWindow() {
 	var mods_formats = rec.types_of_resource();
 	var formats;
 
-	if(holdArgs.recordDescriptors)
+	if (holdArgs.recordDescriptors && holdArgs.recordDescriptors.length)
 		formats = holdArgs.recordDescriptors[0].item_type();
 
 	if( holdArgs.type == 'T' ) {

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/web/opac/skin/default/js/holds.js |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
Evergreen ILS