[open-ils-commits] [GIT] Evergreen ILS branch master updated. 9f628498dadb857afc79fad053d21dfe0bb1c746

Evergreen Git git at git.evergreen-ils.org
Wed May 9 00:23:34 EDT 2012


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  9f628498dadb857afc79fad053d21dfe0bb1c746 (commit)
      from  1492479f314b3ff12539be54ef097a550c099746 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 9f628498dadb857afc79fad053d21dfe0bb1c746
Author: Lebbeous Fogle-Weekley <lebbeous at esilibrary.com>
Date:   Wed Apr 18 10:41:27 2012 -0400

    AutoSuggest: Escape ampersands properly
    
    This fixes an issue reported by Yamil Suarez.
    
    If you had relatively technical users composing searches with
    QueryParser syntax, or if they were just typing ampersands for any
    other reason, AutoSuggest would behave as if the ampersand marked the end
    of user input.
    
    This is fixed by applying the correct URI-encoding function for the
    situation.
    
    To be clear, QueryParser syntax does not actually affect suggestions;
    such syntax is ignored.  AutoSuggest is not search.
    
    Signed-off-by: Lebbeous Fogle-Weekley <lebbeous at esilibrary.com>
    Signed-off-by: Dan Scott <dan at coffeecode.net>

diff --git a/Open-ILS/web/js/dojo/openils/AutoSuggestStore.js b/Open-ILS/web/js/dojo/openils/AutoSuggestStore.js
index b36b6a4..d598159 100644
--- a/Open-ILS/web/js/dojo/openils/AutoSuggestStore.js
+++ b/Open-ILS/web/js/dojo/openils/AutoSuggestStore.js
@@ -132,7 +132,7 @@ if (!dojo._hasResource["openils.AutoSuggestStore"]) {
             term = term.replace(/\*$/, "");
 
             var params = [
-                "query=" + encodeURI(term),
+                "query=" + encodeURIComponent(term),
                 "search_class=" + this.type_selector.value,
                 "limit=" + limit
             ];

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/web/js/dojo/openils/AutoSuggestStore.js |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
Evergreen ILS


More information about the open-ils-commits mailing list