[open-ils-commits] [GIT] Evergreen ILS branch rel_2_3 updated. c6a1c0432c437c3e84384cfa6cf83b05900e02ca

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_2_3 has been updated
       via  c6a1c0432c437c3e84384cfa6cf83b05900e02ca (commit)
      from  9692199c47cb01782cfd3156a2bfd3669fe446e3 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c6a1c0432c437c3e84384cfa6cf83b05900e02ca
Author: Lebbeous Fogle-Weekley <lebbeous at esilibrary.com>
Date:   Fri Sep 28 15:26:06 2012 -0400

    Make scrollOnFocus default to false for dojo-based/conify interfaces
    
    This change is intended to prevent a phenomenon in certain user
    interfaces wherein clicking on a button or other widget can cause a
    user's screen to suddenly jump and the user to need to click the widget
    a second time before the desired function actually happens.
    
    Dijits that have the scrollOnFocus property are the ones that tend to
    exhibit this issue, especially, but not always, within the staff client
    when the user's xulrunner window is not maximized.
    
    There may be cases of interfaces actually relying on scrollOnFocus to do
    something, but I think those cases should be so rare that this is still
    worth doing, and exceptions can be applied there as needed.
    
    Signed-off-by: Lebbeous Fogle-Weekley <lebbeous at esilibrary.com>
    Signed-off-by: Ben Shum <bshum at biblio.org>

diff --git a/Open-ILS/web/js/ui/base.js b/Open-ILS/web/js/ui/base.js
index 8a6d7c9..c6ed445 100644
--- a/Open-ILS/web/js/ui/base.js
+++ b/Open-ILS/web/js/ui/base.js
@@ -1,3 +1,9 @@
+dojo.require('dijit.form._FormWidget');
+
+/* scrollOnFocus is usually terrible, and causes lots of buttons and the like
+ * to require a second click. */
+dijit.form._FormWidget.prototype.scrollOnFocus = false;
+
 dojo.require('dijit.Dialog');
 dojo.require('dojo.cookie');
 dojo.require('fieldmapper.AutoIDL');  // make conditional.  TT variable sets JS var to enable/disable?
@@ -6,7 +12,6 @@ dojo.require('openils.CGI');
 dojo.require('openils.Event');
 dojo.require('openils.Util');
 dojo.require('openils.XUL');
-
 var cgi = new openils.CGI();
 
 function oilsSetupUser() {

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/web/js/ui/base.js |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
Evergreen ILS