[open-ils-commits] [GIT] Evergreen ILS branch rel_2_3 updated. 30d325f369744adf9fb8ebc4d2f200de5d0a7ee2

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_2_3 has been updated
       via  30d325f369744adf9fb8ebc4d2f200de5d0a7ee2 (commit)
      from  d3e30b106d06159c0edf4f9a59e6df5dfd4bd694 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 30d325f369744adf9fb8ebc4d2f200de5d0a7ee2
Author: Steven Chan <schan at sitka.bclibraries.ca>
Date:   Wed Jul 25 13:45:40 2012 -0700

    Fix LP1029095, Acq: Receive Items on an Invoice does not work with Line Item Alerts
    
    1. Item reception was encountering a Javascript exception in the
    check_lineitem_alerts() helper function, because there was a mismatch
    between the input parameter name and the variable name actually used.
    
    2. Also, took the opportunity to improve the performance of the for loop
    to scan through alerts.
    
    Signed-off-by: Bill Erickson <berick at esilibrary.com>

diff --git a/Open-ILS/web/js/ui/default/acq/invoice/receive.js b/Open-ILS/web/js/ui/default/acq/invoice/receive.js
index 1ed65be..d521335 100644
--- a/Open-ILS/web/js/ui/default/acq/invoice/receive.js
+++ b/Open-ILS/web/js/ui/default/acq/invoice/receive.js
@@ -341,13 +341,15 @@ function ReceivableCopyTable() {
             function(o) { return Boolean(o.alert_text()); }
         );
 
-        for (var i = 0; i < alert_notes.length; i++) {
-            if (this.user_has_acked[alert_notes[i].id()])
+        var i, note, n_notes = alert_notes.length;
+        for (i = 0; i < n_notes; i++) {
+            note = alert_notes[i];
+            if (this.user_has_acked[note.id()])
                 continue;
-            else if (!this.confirm_alert(li, alert_notes[i]))
+            else if (!this.confirm_alert(lineitem, note))
                 return false;
             else
-                this.user_has_acked[alert_notes[i].id()] = true;
+                this.user_has_acked[note.id()] = true;
         }
 
         return true;

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/web/js/ui/default/acq/invoice/receive.js |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)


hooks/post-receive
-- 
Evergreen ILS