[open-ils-commits] [GIT] Evergreen ILS branch rel_2_3 updated. 2e4ea92f7090bbd9c8db015e91548d69edfd470a
Evergreen Git
git at git.evergreen-ils.org
Tue Sep 4 16:22:53 EDT 2012
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".
The branch, rel_2_3 has been updated
via 2e4ea92f7090bbd9c8db015e91548d69edfd470a (commit)
from ad51dc50b0fc2829db25dd604fc8241a6bfd10ff (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 2e4ea92f7090bbd9c8db015e91548d69edfd470a
Author: Jared Camins-Esakov <jcamins at cpbibliography.com>
Date: Sat Sep 1 10:21:51 2012 -0400
Bug #1044721: QP handles explicit group+joiner badly
Although the following four queries should be equivalent:
george || fred
(george) || fred
george || (fred)
(george) || (fred)
The Pg QueryParser driver generates SQL queries that return different
numbers of results for each of those queries, with all desired results
appearing only with the first query. This seems to be because of the way
filters are added in the interface.
This patch adjusts the Search code in TPAC to add an explicit group
around the user-entered query, which enables the Pg QueryParser driver
to handle all four of the above queries properly.
This patch should also resolve the problems encountered with the patch
for bug #1040740, "Implicit ANDs should have higher precedence than
explicit ORs"
Signed-off-by: Jared Camins-Esakov <jcamins at cpbibliography.com>
Signed-off-by: Lebbeous Fogle-Weekley <lebbeous at esilibrary.com>
diff --git a/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Search.pm b/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Search.pm
index cfe8853..e66fee2 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Search.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Search.pm
@@ -63,6 +63,7 @@ sub _prepare_biblio_search {
my ($cgi, $ctx) = @_;
my $query = _prepare_biblio_search_basics($cgi) || '';
+ $query = "($query)";
$query .= ' ' . $ctx->{global_search_filter} if $ctx->{global_search_filter};
-----------------------------------------------------------------------
Summary of changes:
.../perlmods/lib/OpenILS/WWW/EGCatLoader/Search.pm | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
hooks/post-receive
--
Evergreen ILS
More information about the open-ils-commits
mailing list