[open-ils-commits] [GIT] Evergreen ILS branch master updated. c22418f9a1adf9af2734bd76d97d6acf938750d3

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  c22418f9a1adf9af2734bd76d97d6acf938750d3 (commit)
       via  4eb066033edea348660a0e54a45cdec8528804dc (commit)
      from  5fe3ec70460bdd75af7bccd2967ccb62dd475c81 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit c22418f9a1adf9af2734bd76d97d6acf938750d3
Author: Ben Shum <bshum at biblio.org>
Date:   Tue Aug 6 12:20:33 2013 -0400

    Add release note for checkout trimming whitespaces from beginning and end of barcodes
    
    Signed-off-by: Ben Shum <bshum at biblio.org>

diff --git a/docs/RELEASE_NOTES_NEXT/Circulation/trim-whitespace-checkout.txt b/docs/RELEASE_NOTES_NEXT/Circulation/trim-whitespace-checkout.txt
new file mode 100644
index 0000000..76c8bcd
--- /dev/null
+++ b/docs/RELEASE_NOTES_NEXT/Circulation/trim-whitespace-checkout.txt
@@ -0,0 +1,6 @@
+Checkout: Trim whitespace from beginning and end of barcode
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+
+In checkout, when pasting a barcode into the lookup field, one may accidentally
+include spaces or tabs in the beginning or end of the barcode string. Trim 
+those away to avoid potential mis-scans.

commit 4eb066033edea348660a0e54a45cdec8528804dc
Author: Pasi Kallinen <pasi.kallinen at pttk.fi>
Date:   Tue Jul 2 19:36:53 2013 +0300

    Trim whitespace from beginning and end of the barcode in checkout.
    
    Signed-off-by: Pasi Kallinen <pasi.kallinen at pttk.fi>
    Signed-off-by: Ben Shum <bshum at biblio.org>

diff --git a/Open-ILS/xul/staff_client/server/circ/checkout.js b/Open-ILS/xul/staff_client/server/circ/checkout.js
index 56d5ef8..78ae98b 100644
--- a/Open-ILS/xul/staff_client/server/circ/checkout.js
+++ b/Open-ILS/xul/staff_client/server/circ/checkout.js
@@ -113,7 +113,7 @@ circ.checkout.prototype = {
                         ['keypress'],
                         function(ev) {
                             if (ev.keyCode && ev.keyCode == 13) {
-                                obj.checkout( { barcode: ev.target.value } );
+                                obj.checkout( { barcode: ev.target.value.trim() } );
                             }
                         }
                     ],
@@ -143,7 +143,7 @@ circ.checkout.prototype = {
 
                             if (obj.controller.view.checkout_menu.value == 'barcode' ||
                                 obj.controller.view.checkout_menu.value === '') {
-                                params.barcode = obj.controller.view.checkout_barcode_entry_textbox.value;
+                                params.barcode = obj.controller.view.checkout_barcode_entry_textbox.value.trim();
                             } else {
                                 params.noncat = 1;
                                 params.noncat_type = obj.controller.view.checkout_menu.value;

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/xul/staff_client/server/circ/checkout.js  |    4 ++--
 .../Circulation/trim-whitespace-checkout.txt       |    6 ++++++
 2 files changed, 8 insertions(+), 2 deletions(-)
 create mode 100644 docs/RELEASE_NOTES_NEXT/Circulation/trim-whitespace-checkout.txt


hooks/post-receive
-- 
Evergreen ILS