[open-ils-commits] [GIT] Evergreen ILS branch rel_2_4 updated. 11a2542c75dc04f5a86e4206b182b927d4f845aa

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_2_4 has been updated
       via  11a2542c75dc04f5a86e4206b182b927d4f845aa (commit)
      from  baa8f926f7a4ce0e86aa419ba64cca7b509b8d45 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 11a2542c75dc04f5a86e4206b182b927d4f845aa
Author: Bill Erickson <berick at esilibrary.com>
Date:   Tue Aug 13 10:03:10 2013 -0400

    LP1211506 fix numeric sorting in staff client grids
    
    To recover numeric (vs. ascii-betical) sorting of number and money
    values in grids, cast the cached sort values back into numbers.
    
    This was tested in the billing interface, but should repair numeric
    sorting for most grids.
    
    Signed-off-by: Bill Erickson <berick at esilibrary.com>
    Signed-off-by: Jason Etheridge <jason at esilibrary.com>
    Signed-off-by: Ben Shum <bshum at biblio.org>

diff --git a/Open-ILS/xul/staff_client/chrome/content/util/list.js b/Open-ILS/xul/staff_client/chrome/content/util/list.js
index 1ddfb0f..d4e5039 100644
--- a/Open-ILS/xul/staff_client/chrome/content/util/list.js
+++ b/Open-ILS/xul/staff_client/chrome/content/util/list.js
@@ -1784,6 +1784,14 @@ util.list.prototype = {
                                 if (a.sort_value) {
                                     a = a.sort_value;
                                     b = b.sort_value;
+
+                                    // ensure that numeric values have not
+                                    // morphed into strings along the way.
+                                    if (obj.columns[p].sort_type == 'money' ||
+                                        obj.columns[p].sort_type == 'number') {
+                                        a = Number(a);
+                                        b = Number(b);
+                                    }
                                 } else {
                                     a = a.value;
                                     b = b.value;

-----------------------------------------------------------------------

Summary of changes:
 .../xul/staff_client/chrome/content/util/list.js   |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)


hooks/post-receive
-- 
Evergreen ILS