[open-ils-commits] [GIT] Evergreen ILS branch master updated. 80e3f6f63a6e8ce422e6b2e1f7c981a7c2e5ff49

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  80e3f6f63a6e8ce422e6b2e1f7c981a7c2e5ff49 (commit)
      from  fb37e15ec7476be5a8c772595d613853e3e11019 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 80e3f6f63a6e8ce422e6b2e1f7c981a7c2e5ff49
Author: Mike Rylander <mrylander at gmail.com>
Date:   Wed Aug 14 10:25:14 2013 -0400

    Correctly mark nested INNER joins as such
    
    We've been adopting containing the JOINs flavor, and then
    attempting to use IS NOT NULL to restrict NULL-ness
    in the WHERE clause.  This is almost right, but not quite,
    and was done in an attempt to match behavior with the
    expectations of users that are not SQL experts.  However,
    right is better than "looks right most of the time", so
    we use the proper join type now.
    
    Signed-off-by: Mike Rylander <mrylander at gmail.com>
    Signed-off-by: Jason Boyer <jboyer1 at library.in.gov>
    Signed-off-by: Mike Rylander <mrylander at gmail.com>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Reporter/SQLBuilder.pm b/Open-ILS/src/perlmods/lib/OpenILS/Reporter/SQLBuilder.pm
index 67c8af6..940972a 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Reporter/SQLBuilder.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Reporter/SQLBuilder.pm
@@ -1213,7 +1213,7 @@ sub toSQL {
     my $_nullable_rel = $dir && $dir eq 'l' ? '_right_rel' : '_left_rel';
     $self->{$_nullable_rel}->{_nullable} = $dir;
 
-    my $j = $dir ? ( $dir eq 'l' ? 'LEFT OUTER' : ( $dir eq 'r' ? 'RIGHT OUTER' : 'FULL OUTER' ) ) : 'INNER';
+    my $j = 'INNER';
 
     my $sql = "\n\t$j ". $self->SUPER::toSQL;
 

-----------------------------------------------------------------------

Summary of changes:
 .../perlmods/lib/OpenILS/Reporter/SQLBuilder.pm    |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
Evergreen ILS