[open-ils-commits] [GIT] Evergreen ILS branch rel_2_3 updated. 99cc0c0fe9550f5d0731f042df8341de46ed1198

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_2_3 has been updated
       via  99cc0c0fe9550f5d0731f042df8341de46ed1198 (commit)
      from  3e7f6f8bdf1c11b557df000c22d6809cc8e62698 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 99cc0c0fe9550f5d0731f042df8341de46ed1198
Author: Mike Rylander <mrylander at gmail.com>
Date:   Wed Aug 14 10:25:14 2013 -0400

    Correctly mark nested INNER joins as such
    
    We've been adopting containing the JOINs flavor, and then
    attempting to use IS NOT NULL to restrict NULL-ness
    in the WHERE clause.  This is almost right, but not quite,
    and was done in an attempt to match behavior with the
    expectations of users that are not SQL experts.  However,
    right is better than "looks right most of the time", so
    we use the proper join type now.
    
    Signed-off-by: Mike Rylander <mrylander at gmail.com>
    Signed-off-by: Jason Boyer <jboyer1 at library.in.gov>
    
    Conflicts [just whitespace style]:
    	Open-ILS/src/perlmods/lib/OpenILS/Reporter/SQLBuilder.pm

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Reporter/SQLBuilder.pm b/Open-ILS/src/perlmods/lib/OpenILS/Reporter/SQLBuilder.pm
index b7d7177..21ad928 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Reporter/SQLBuilder.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Reporter/SQLBuilder.pm
@@ -1213,7 +1213,7 @@ sub toSQL {
 	my $_nullable_rel = $dir && $dir eq 'l' ? '_right_rel' : '_left_rel';
 	$self->{$_nullable_rel}->{_nullable} = $dir;
 
-	my $j = $dir ? ( $dir eq 'l' ? 'LEFT OUTER' : ( $dir eq 'r' ? 'RIGHT OUTER' : 'FULL OUTER' ) ) : 'INNER';
+	my $j = 'INNER';
 
 	my $sql = "\n\t$j ". $self->SUPER::toSQL;
 

-----------------------------------------------------------------------

Summary of changes:
 .../perlmods/lib/OpenILS/Reporter/SQLBuilder.pm    |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
Evergreen ILS