[open-ils-commits] [GIT] Evergreen ILS branch master updated. 2920f7a11fba60de2e9ca7c8ec9a0482cd7ac939

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  2920f7a11fba60de2e9ca7c8ec9a0482cd7ac939 (commit)
      from  a997ffe33fa865e212189717ba1799d97fbeb62d (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 2920f7a11fba60de2e9ca7c8ec9a0482cd7ac939
Author: Jason Etheridge <jason at esilibrary.com>
Date:   Thu Sep 20 13:10:15 2012 -0400

    LP1053526 - Don't inadvertently modify the in-memory org tree when printing
    
    To see an example of this causing a problem, load Holdings Maintenance for
    an arbitrary bib record with items. Make sure the Hide Empty Libs checkbox
    is checked. Hit the Print button at the bottom of the UI (it's okay to then
    Cancel the print). Then hit Refresh. It should result in an org.children()
    is null error.
    
    Signed-off-by: Jason Etheridge <jason at esilibrary.com>
    Signed-off-by: Ben Shum <bshum at biblio.org>

diff --git a/Open-ILS/xul/staff_client/chrome/content/util/list.js b/Open-ILS/xul/staff_client/chrome/content/util/list.js
index 9b37385..e9bf29a 100644
--- a/Open-ILS/xul/staff_client/chrome/content/util/list.js
+++ b/Open-ILS/xul/staff_client/chrome/content/util/list.js
@@ -1574,8 +1574,8 @@ util.list.prototype = {
                 params.staff = data.list.au[0];
             }
             if (!params.lib && data.list.au && data.list.au[0] && data.list.au[0].ws_ou() && data.hash.aou && data.hash.aou[ data.list.au[0].ws_ou() ]) {
-                params.lib = data.hash.aou[ data.list.au[0].ws_ou() ];
-                params.lib.children(null);
+                params.lib = JSON2js( js2JSON( data.hash.aou[ data.list.au[0].ws_ou() ] ) ); // clone this sucker
+                params.lib.children(null); // since we're modifying it
             }
             if (params.template && data.print_list_templates[ params.template ]) {
                 var template = data.print_list_templates[ params.template ];

-----------------------------------------------------------------------

Summary of changes:
 .../xul/staff_client/chrome/content/util/list.js   |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
Evergreen ILS