[open-ils-commits] [GIT] Evergreen ILS branch master updated. a7da0c23c6c7392dbc2c9fa25a816a66708d8e2d
Evergreen Git
git at git.evergreen-ils.org
Fri Feb 8 17:37:32 EST 2013
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".
The branch, master has been updated
via a7da0c23c6c7392dbc2c9fa25a816a66708d8e2d (commit)
via 15ebe4fa801a378b88681398d3c2dd9614308da6 (commit)
via f37b1e87e6fec295df2dd97ed39725860ec26270 (commit)
via 1c1ace019cbd870bdf4636f5049dc306c0d3772e (commit)
from 25f8ba16c8825e42c3a154b61b3ee0b0b4a6ab10 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit a7da0c23c6c7392dbc2c9fa25a816a66708d8e2d
Author: Ben Shum <bshum at biblio.org>
Date: Fri Feb 8 17:30:52 2013 -0500
Add release note for clickable patron indicators
Signed-off-by: Ben Shum <bshum at biblio.org>
diff --git a/docs/RELEASE_NOTES_NEXT/clickable_patron_indicators.txt b/docs/RELEASE_NOTES_NEXT/clickable_patron_indicators.txt
new file mode 100644
index 0000000..4d0baee
--- /dev/null
+++ b/docs/RELEASE_NOTES_NEXT/clickable_patron_indicators.txt
@@ -0,0 +1,6 @@
+New feature: Clickable Patron Indicators
+========================================
+When retrieving a patron record, staff can now click on the indicators listed
+beneath the patron's name and launch the related tabs.
+
+For example, clicking on (See Notes) will open the associated patron's notes.
commit 15ebe4fa801a378b88681398d3c2dd9614308da6
Author: Kathy Lussier <klussier at masslnc.org>
Date: Fri Feb 8 16:41:43 2013 -0500
Remove See Messages from the invalid email and phone labels
The "See Messages" part of the label might be misleading since clicking these
indicators opens the patron edit screen. Since replacing the email or
phone number automatically removes these messages, there is no need to
direct the user to the messages screen.
Signed-off-by: Kathy Lussier <klussier at masslnc.org>
Signed-off-by: Ben Shum <bshum at biblio.org>
diff --git a/Open-ILS/web/opac/locale/en-US/lang.dtd b/Open-ILS/web/opac/locale/en-US/lang.dtd
index 4957a7d..2721d40 100644
--- a/Open-ILS/web/opac/locale/en-US/lang.dtd
+++ b/Open-ILS/web/opac/locale/en-US/lang.dtd
@@ -3224,8 +3224,8 @@
<!ENTITY staff.patron.display_overlay.has_overdues.value "(Has Overdues)">
<!ENTITY staff.patron.display_overlay.invalid_dob.value "(Invalid Date of Birth)">
<!ENTITY staff.patron.display_overlay.invalid_address.value "(Invalid Address)">
-<!ENTITY staff.patron.display_overlay.invalid_email.value "(Invalid Email - See Messages)">
-<!ENTITY staff.patron.display_overlay.invalid_phone.value "(Invalid Phone - See Messages)">
+<!ENTITY staff.patron.display_overlay.invalid_email.value "(Invalid Email)">
+<!ENTITY staff.patron.display_overlay.invalid_phone.value "(Invalid Phone)">
<!ENTITY staff.patron.display_overlay.exit.label "Exit">
<!ENTITY staff.patron.display_overlay.exit.accesskey "x">
<!ENTITY staff.patron.display_overlay.search_form.label "Search Form">
commit f37b1e87e6fec295df2dd97ed39725860ec26270
Author: Thomas Berezansky <tsbere at mvlc.org>
Date: Thu Oct 11 13:34:32 2012 -0400
Stop highlighting indicators
The way that commands were highlighted when selected, highlighted
both the indicators and the buttons. Change to only hightlight
the tabbed buttons.
Signed-off-by: Thomas Berezansky <tsbere at mvlc.org>
Signed-off-by: Ben Shum <bshum at biblio.org>
Signed-off-by: Kathy Lussier <klussier at masslnc.org>
diff --git a/Open-ILS/xul/staff_client/server/patron/display.js b/Open-ILS/xul/staff_client/server/patron/display.js
index 03c350f..33fead8 100644
--- a/Open-ILS/xul/staff_client/server/patron/display.js
+++ b/Open-ILS/xul/staff_client/server/patron/display.js
@@ -692,14 +692,12 @@ patron.display.prototype = {
this.skip_hide_summary = false;
dont_hide_summary = true;
}
- this.controller.view.cmd_patron_checkout.setAttribute('style','');
- this.controller.view.cmd_patron_items.setAttribute('style','');
- this.controller.view.cmd_patron_edit.setAttribute('style','');
- this.controller.view.cmd_patron_other.setAttribute('style','');
- this.controller.view.cmd_patron_holds.setAttribute('style','');
- this.controller.view.cmd_patron_bills.setAttribute('style','');
- this.controller.view.cmd_standing_penalties.setAttribute('style','');
- this.controller.view[ btn ].setAttribute('style','background: blue; color: white;');
+ var buttons = document.getElementsByTagName('button');
+ for(var i = 0; i < buttons.length; i++) {
+ var command = buttons[i].getAttribute('command');
+ if(command == btn) buttons[i].setAttribute('style','background: blue; color: white;');
+ else buttons[i].setAttribute('style','');
+ }
var auto_hide_patron_sidebar = String( this.OpenILS.data.hash.aous['circ.auto_hide_patron_summary'] ) == 'true';
var x = document.getElementById('splitter_grippy');
if (x && auto_hide_patron_sidebar && ! dont_hide_summary) {
commit 1c1ace019cbd870bdf4636f5049dc306c0d3772e
Author: Thomas Berezansky <tsbere at mvlc.org>
Date: Wed Oct 3 15:27:54 2012 -0400
Make patron indicators clickable
For example, make "(See Notes)" bring you to notes, provided the patron is
already loaded (aka, not from search).
Signed-off-by: Thomas Berezansky <tsbere at mvlc.org>
Signed-off-by: Ben Shum <bshum at biblio.org>
Signed-off-by: Kathy Lussier <klussier at masslnc.org>
diff --git a/Open-ILS/xul/staff_client/server/patron/display.js b/Open-ILS/xul/staff_client/server/patron/display.js
index 3530f71..03c350f 100644
--- a/Open-ILS/xul/staff_client/server/patron/display.js
+++ b/Open-ILS/xul/staff_client/server/patron/display.js
@@ -626,6 +626,13 @@ patron.display.prototype = {
try { window.xulG.set_tab_name($("patronStrings").getString('staff.patron.display.init.retrieving_patron')); } catch(E) { alert(E); }
}
+ var displayClickies = document.getElementById("pdm2hb1a").getElementsByTagName("label");
+ for (var i = 0; i < displayClickies.length; i++) {
+ if (displayClickies[i].getAttribute('command')) {
+ displayClickies[i].setAttribute('onclick', 'this.doCommand();');
+ }
+ }
+
obj.controller.view.PatronNavBar.selectedIndex = 1;
JSAN.use('util.widgets');
util.widgets.enable_accesskeys_in_node_and_children(
diff --git a/Open-ILS/xul/staff_client/server/patron/display_horiz_overlay.xul b/Open-ILS/xul/staff_client/server/patron/display_horiz_overlay.xul
index 085fd5f..f1a1361 100644
--- a/Open-ILS/xul/staff_client/server/patron/display_horiz_overlay.xul
+++ b/Open-ILS/xul/staff_client/server/patron/display_horiz_overlay.xul
@@ -18,20 +18,20 @@
<deck id="PatronNavBar" flex="1" class="my_overflow" />
</hbox>
<hbox id="pdm2hb1a">
- <label class="hideme barred_indicator" value="&staff.patron.display_overlay.barred.value;"/>
- <label class="hideme expired_indicator" value="&staff.patron.display_overlay.expired.value;"/>
- <label class="hideme inactive_indicator" value="&staff.patron.display_overlay.inactive.value;"/>
- <label class="hideme juvenile_indicator" value="&staff.patron.display_overlay.juvenile.value;"/>
- <label class="hideme alert_indicator" value="&staff.patron.display_overlay.alert.value;"/>
- <label class="hideme note_indicator" value="&staff.patron.display_overlay.see_notes.value;"/>
- <label class="hideme max_bills_indicator" value="&staff.patron.display_overlay.max_bills.value;"/>
- <label class="hideme max_overdues_indicator" value="&staff.patron.display_overlay.max_overdues.value;"/>
- <label class="hideme bills_indicator" value="&staff.patron.display_overlay.has_bills.value;"/>
- <label class="hideme overdues_indicator" value="&staff.patron.display_overlay.has_overdues.value;"/>
- <label class="hideme invalid_dob_indicator" value="&staff.patron.display_overlay.invalid_dob.value;"/>
- <label class="hideme invalid_address_indicator" value="&staff.patron.display_overlay.invalid_address.value;"/>
- <label class="hideme invalid_email_indicator" value="&staff.patron.display_overlay.invalid_email.value;"/>
- <label class="hideme invalid_phone_indicator" value="&staff.patron.display_overlay.invalid_phone.value;"/>
+ <label class="hideme barred_indicator" value="&staff.patron.display_overlay.barred.value;" command="cmd_patron_edit"/>
+ <label class="hideme expired_indicator" value="&staff.patron.display_overlay.expired.value;" command="cmd_patron_edit"/>
+ <label class="hideme inactive_indicator" value="&staff.patron.display_overlay.inactive.value;" command="cmd_patron_edit"/>
+ <label class="hideme juvenile_indicator" value="&staff.patron.display_overlay.juvenile.value;" command="cmd_patron_edit"/>
+ <label class="hideme alert_indicator" value="&staff.patron.display_overlay.alert.value;" command="cmd_patron_edit"/>
+ <label class="hideme note_indicator" value="&staff.patron.display_overlay.see_notes.value;" command="cmd_patron_info_notes"/>
+ <label class="hideme max_bills_indicator" value="&staff.patron.display_overlay.max_bills.value;" command="cmd_patron_bills"/>
+ <label class="hideme max_overdues_indicator" value="&staff.patron.display_overlay.max_overdues.value;" command="cmd_patron_items"/>
+ <label class="hideme bills_indicator" value="&staff.patron.display_overlay.has_bills.value;" command="cmd_patron_bills"/>
+ <label class="hideme overdues_indicator" value="&staff.patron.display_overlay.has_overdues.value;" command="cmd_patron_items"/>
+ <label class="hideme invalid_dob_indicator" value="&staff.patron.display_overlay.invalid_dob.value;" command="cmd_patron_edit"/>
+ <label class="hideme invalid_address_indicator" value="&staff.patron.display_overlay.invalid_address.value;" command="cmd_patron_edit"/>
+ <label class="hideme invalid_email_indicator" value="&staff.patron.display_overlay.invalid_email.value;" command="cmd_patron_edit"/>
+ <label class="hideme invalid_phone_indicator" value="&staff.patron.display_overlay.invalid_phone.value;" command="cmd_patron_edit"/>
</hbox>
<vbox id="PatronNotNavBar" flex="1" class="my_bg">
<hbox id="left_deck_vbox" flex="1" oils_persist="height">
diff --git a/Open-ILS/xul/staff_client/server/patron/display_overlay.xul b/Open-ILS/xul/staff_client/server/patron/display_overlay.xul
index 876e137..fdbee54 100644
--- a/Open-ILS/xul/staff_client/server/patron/display_overlay.xul
+++ b/Open-ILS/xul/staff_client/server/patron/display_overlay.xul
@@ -18,20 +18,20 @@
<deck id="PatronNavBar" flex="1" class="my_overflow" />
</hbox>
<hbox id="pdm2hb1a">
- <label class="hideme barred_indicator" value="&staff.patron.display_overlay.barred.value;"/>
- <label class="hideme expired_indicator" value="&staff.patron.display_overlay.expired.value;"/>
- <label class="hideme inactive_indicator" value="&staff.patron.display_overlay.inactive.value;"/>
- <label class="hideme juvenile_indicator" value="&staff.patron.display_overlay.juvenile.value;"/>
- <label class="hideme alert_indicator" value="&staff.patron.display_overlay.alert.value;"/>
- <label class="hideme note_indicator" value="&staff.patron.display_overlay.see_notes.value;"/>
- <label class="hideme max_bills_indicator" value="&staff.patron.display_overlay.max_bills.value;"/>
- <label class="hideme max_overdues_indicator" value="&staff.patron.display_overlay.max_overdues.value;"/>
- <label class="hideme bills_indicator" value="&staff.patron.display_overlay.has_bills.value;"/>
- <label class="hideme overdues_indicator" value="&staff.patron.display_overlay.has_overdues.value;"/>
- <label class="hideme invalid_dob_indicator" value="&staff.patron.display_overlay.invalid_dob.value;"/>
- <label class="hideme invalid_address_indicator" value="&staff.patron.display_overlay.invalid_address.value;"/>
- <label class="hideme invalid_email_indicator" value="&staff.patron.display_overlay.invalid_email.value;"/>
- <label class="hideme invalid_phone_indicator" value="&staff.patron.display_overlay.invalid_phone.value;"/>
+ <label class="hideme barred_indicator" value="&staff.patron.display_overlay.barred.value;" command="cmd_patron_edit"/>
+ <label class="hideme expired_indicator" value="&staff.patron.display_overlay.expired.value;" command="cmd_patron_edit"/>
+ <label class="hideme inactive_indicator" value="&staff.patron.display_overlay.inactive.value;" command="cmd_patron_edit"/>
+ <label class="hideme juvenile_indicator" value="&staff.patron.display_overlay.juvenile.value;" command="cmd_patron_edit"/>
+ <label class="hideme alert_indicator" value="&staff.patron.display_overlay.alert.value;" command="cmd_patron_edit"/>
+ <label class="hideme note_indicator" value="&staff.patron.display_overlay.see_notes.value;" command="cmd_patron_info_notes"/>
+ <label class="hideme max_bills_indicator" value="&staff.patron.display_overlay.max_bills.value;" command="cmd_patron_bills"/>
+ <label class="hideme max_overdues_indicator" value="&staff.patron.display_overlay.max_overdues.value;" command="cmd_patron_items"/>
+ <label class="hideme bills_indicator" value="&staff.patron.display_overlay.has_bills.value;" command="cmd_patron_bills"/>
+ <label class="hideme overdues_indicator" value="&staff.patron.display_overlay.has_overdues.value;" command="cmd_patron_items"/>
+ <label class="hideme invalid_dob_indicator" value="&staff.patron.display_overlay.invalid_dob.value;" command="cmd_patron_edit"/>
+ <label class="hideme invalid_address_indicator" value="&staff.patron.display_overlay.invalid_address.value;" command="cmd_patron_edit"/>
+ <label class="hideme invalid_email_indicator" value="&staff.patron.display_overlay.invalid_email.value;" command="cmd_patron_edit"/>
+ <label class="hideme invalid_phone_indicator" value="&staff.patron.display_overlay.invalid_phone.value;" command="cmd_patron_edit"/>
</hbox>
<hbox id="PatronNotNavBar" flex="1" class="my_bg">
<vbox id="left_deck_vbox" flex="1" oils_persist="width">
-----------------------------------------------------------------------
Summary of changes:
Open-ILS/web/opac/locale/en-US/lang.dtd | 4 +-
Open-ILS/xul/staff_client/server/patron/display.js | 21 +++++++++-----
.../server/patron/display_horiz_overlay.xul | 28 ++++++++++----------
.../staff_client/server/patron/display_overlay.xul | 28 ++++++++++----------
.../clickable_patron_indicators.txt | 6 ++++
5 files changed, 49 insertions(+), 38 deletions(-)
create mode 100644 docs/RELEASE_NOTES_NEXT/clickable_patron_indicators.txt
hooks/post-receive
--
Evergreen ILS
More information about the open-ils-commits
mailing list