[open-ils-commits] [GIT] Evergreen ILS branch master updated. 8cfad95dac348c1ae32477c3e9c3832adaeaaa8e

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  8cfad95dac348c1ae32477c3e9c3832adaeaaa8e (commit)
       via  284f3ff0a1669b8562785beae74e51012eeb04b0 (commit)
       via  d16ff8e27e777de88cf09d47c6d01197b1cfd18f (commit)
      from  e3e4c1de32553d74bd43a5ca4139c8ba2244bcaf (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 8cfad95dac348c1ae32477c3e9c3832adaeaaa8e
Author: Jason Stephenson <jstephenson at mvlc.org>
Date:   Fri Nov 9 15:06:04 2012 -0500

    Stop requiring unneeded/absent RPC::XML::Method
    
    It's not a thing in recent versions of RPC::XML
    
    Signed-off-by: Jason Stephenson <jstephenson at mvlc.org>

diff --git a/Open-ILS/src/perlmods/Build.PL b/Open-ILS/src/perlmods/Build.PL
index ead859d..c78af11 100644
--- a/Open-ILS/src/perlmods/Build.PL
+++ b/Open-ILS/src/perlmods/Build.PL
@@ -68,7 +68,6 @@ my $build = Module::Build->new(
         'POSIX' => '0',
         'RPC::XML' => '0',
         'RPC::XML::Client' => '0',
-        'RPC::XML::Method' => '0',
         'RPC::XML::Parser' => '0',
         'RPC::XML::Procedure' => '0',
         'Safe' => '0',
diff --git a/Open-ILS/src/perlmods/lib/OpenILS/WWW/XMLRPCGateway.pm b/Open-ILS/src/perlmods/lib/OpenILS/WWW/XMLRPCGateway.pm
index 9e4a4c1..b159fe4 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/WWW/XMLRPCGateway.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/WWW/XMLRPCGateway.pm
@@ -20,7 +20,6 @@ use OpenSRF::Utils::SettingsClient;
 
 use RPC::XML qw/smart_encode/;
 use RPC::XML::Parser;
-use RPC::XML::Method;
 use RPC::XML::Procedure;
 
 $RPC::XML::ENCODING = 'utf-8';

commit 284f3ff0a1669b8562785beae74e51012eeb04b0
Author: Lebbeous Fogle-Weekley <lebbeous at esilibrary.com>
Date:   Mon Oct 22 18:42:55 2012 -0400

    In XML-RPC Gateway, substitute __ for - in method names
    
    Dashes have never actually been valid in XML-RPC method names, and some
    clients (like newer versions of Perl's RPC::XML) enforce this rule on
    their clients.  This way we give XML-RPC clients a way they can still reach
    our methods.
    
    Signed-off-by: Lebbeous Fogle-Weekley <lebbeous at esilibrary.com>
    Signed-off-by: Jason Stephenson <jstephenson at mvlc.org>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/WWW/XMLRPCGateway.pm b/Open-ILS/src/perlmods/lib/OpenILS/WWW/XMLRPCGateway.pm
index 42b69f6..9e4a4c1 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/WWW/XMLRPCGateway.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/WWW/XMLRPCGateway.pm
@@ -85,6 +85,11 @@ sub handler {
 sub run_request {
     my( $service, $method, @args ) = @_;
 
+    $method =~ s/__/-/g;    # Our methods have dashes in them, but that's not
+                            # actually a valid character in XML-RPC method
+                            # names, and some clients enforce that restriction
+                            # on their users.
+
     # since multiple Perl clients run within mod_perl, 
     # we must set our ingress before each request.
     OpenSRF::AppSession->ingress('xmlrpc');

commit d16ff8e27e777de88cf09d47c6d01197b1cfd18f
Author: Lebbeous Fogle-Weekley <lebbeous at esilibrary.com>
Date:   Mon Oct 22 18:19:03 2012 -0400

    Stop requiring unneeded/absent RPC::XML::Function
    
    It's not a thing in recent versions of RPC::XML
    
    Signed-off-by: Lebbeous Fogle-Weekley <lebbeous at esilibrary.com>
    Signed-off-by: Jason Stephenson <jstephenson at mvlc.org>
    Signed-off-by: Dan Scott <dan at coffeecode.net>
    
    Conflicts:
    	Open-ILS/src/extras/Makefile.install

diff --git a/Open-ILS/src/extras/Makefile.install b/Open-ILS/src/extras/Makefile.install
index 94942bd..d3ed369 100644
--- a/Open-ILS/src/extras/Makefile.install
+++ b/Open-ILS/src/extras/Makefile.install
@@ -250,7 +250,6 @@ CPAN_MODULES_FORCE = \
 
 # Lucid Lynx needs the following additional CPAN modules.
 CPAN_MODULES_LUCID = \
-    RPC::XML::Function \
     Rose::URI
 
 # Precise Pangolin needs the following CPAN modules. All others are
@@ -259,7 +258,6 @@ CPAN_MODULES_PRECISE = \
     Business::CreditCard::Object \
     Business::OnlinePayment::PayPal \
     Template::Plugin::POSIX \
-    RPC::XML::Function \
     Rose::URI
 
 # ----------------------------------------------------------------------------
diff --git a/Open-ILS/src/perlmods/Build.PL b/Open-ILS/src/perlmods/Build.PL
index e2bb24e..ead859d 100644
--- a/Open-ILS/src/perlmods/Build.PL
+++ b/Open-ILS/src/perlmods/Build.PL
@@ -68,7 +68,6 @@ my $build = Module::Build->new(
         'POSIX' => '0',
         'RPC::XML' => '0',
         'RPC::XML::Client' => '0',
-        'RPC::XML::Function' => '0',
         'RPC::XML::Method' => '0',
         'RPC::XML::Parser' => '0',
         'RPC::XML::Procedure' => '0',
diff --git a/Open-ILS/src/perlmods/lib/OpenILS/WWW/XMLRPCGateway.pm b/Open-ILS/src/perlmods/lib/OpenILS/WWW/XMLRPCGateway.pm
index 554c1af..42b69f6 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/WWW/XMLRPCGateway.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/WWW/XMLRPCGateway.pm
@@ -20,7 +20,6 @@ use OpenSRF::Utils::SettingsClient;
 
 use RPC::XML qw/smart_encode/;
 use RPC::XML::Parser;
-use RPC::XML::Function;
 use RPC::XML::Method;
 use RPC::XML::Procedure;
 

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/src/extras/Makefile.install               |    2 --
 Open-ILS/src/perlmods/Build.PL                     |    2 --
 .../src/perlmods/lib/OpenILS/WWW/XMLRPCGateway.pm  |    7 +++++--
 3 files changed, 5 insertions(+), 6 deletions(-)


hooks/post-receive
-- 
Evergreen ILS