[open-ils-commits] [GIT] Evergreen ILS branch rel_2_2 updated. 8567665d9df9f778d414ab46fd267611f6e206ec

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_2_2 has been updated
       via  8567665d9df9f778d414ab46fd267611f6e206ec (commit)
       via  4901bdc41f9b31fcf856ffdc2f75a7ea2e4a8d85 (commit)
       via  9b8adeeab9dd0f86cd78f449b0c6869682b55cc5 (commit)
      from  4e266eaf972370051a12bbd4be04b536e6326010 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 8567665d9df9f778d414ab46fd267611f6e206ec
Author: Jason Stephenson <jstephenson at mvlc.org>
Date:   Fri Nov 9 15:06:04 2012 -0500

    Stop requiring unneeded/absent RPC::XML::Method
    
    It's not a thing in recent versions of RPC::XML
    
    Signed-off-by: Jason Stephenson <jstephenson at mvlc.org>

diff --git a/Open-ILS/src/perlmods/Build.PL b/Open-ILS/src/perlmods/Build.PL
index 0906965..77a1440 100644
--- a/Open-ILS/src/perlmods/Build.PL
+++ b/Open-ILS/src/perlmods/Build.PL
@@ -69,7 +69,6 @@ my $build = Module::Build->new(
         'POSIX' => '0',
         'RPC::XML' => '0',
         'RPC::XML::Client' => '0',
-        'RPC::XML::Method' => '0',
         'RPC::XML::Parser' => '0',
         'RPC::XML::Procedure' => '0',
         'Safe' => '0',
diff --git a/Open-ILS/src/perlmods/lib/OpenILS/WWW/XMLRPCGateway.pm b/Open-ILS/src/perlmods/lib/OpenILS/WWW/XMLRPCGateway.pm
index 9e4a4c1..b159fe4 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/WWW/XMLRPCGateway.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/WWW/XMLRPCGateway.pm
@@ -20,7 +20,6 @@ use OpenSRF::Utils::SettingsClient;
 
 use RPC::XML qw/smart_encode/;
 use RPC::XML::Parser;
-use RPC::XML::Method;
 use RPC::XML::Procedure;
 
 $RPC::XML::ENCODING = 'utf-8';

commit 4901bdc41f9b31fcf856ffdc2f75a7ea2e4a8d85
Author: Lebbeous Fogle-Weekley <lebbeous at esilibrary.com>
Date:   Mon Oct 22 18:42:55 2012 -0400

    In XML-RPC Gateway, substitute __ for - in method names
    
    Dashes have never actually been valid in XML-RPC method names, and some
    clients (like newer versions of Perl's RPC::XML) enforce this rule on
    their clients.  This way we give XML-RPC clients a way they can still reach
    our methods.
    
    Signed-off-by: Lebbeous Fogle-Weekley <lebbeous at esilibrary.com>
    Signed-off-by: Jason Stephenson <jstephenson at mvlc.org>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/WWW/XMLRPCGateway.pm b/Open-ILS/src/perlmods/lib/OpenILS/WWW/XMLRPCGateway.pm
index 42b69f6..9e4a4c1 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/WWW/XMLRPCGateway.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/WWW/XMLRPCGateway.pm
@@ -85,6 +85,11 @@ sub handler {
 sub run_request {
     my( $service, $method, @args ) = @_;
 
+    $method =~ s/__/-/g;    # Our methods have dashes in them, but that's not
+                            # actually a valid character in XML-RPC method
+                            # names, and some clients enforce that restriction
+                            # on their users.
+
     # since multiple Perl clients run within mod_perl, 
     # we must set our ingress before each request.
     OpenSRF::AppSession->ingress('xmlrpc');

commit 9b8adeeab9dd0f86cd78f449b0c6869682b55cc5
Author: Lebbeous Fogle-Weekley <lebbeous at esilibrary.com>
Date:   Mon Oct 22 18:19:03 2012 -0400

    Stop requiring unneeded/absent RPC::XML::Function
    
    It's not a thing in recent versions of RPC::XML
    
    Signed-off-by: Lebbeous Fogle-Weekley <lebbeous at esilibrary.com>
    Signed-off-by: Jason Stephenson <jstephenson at mvlc.org>
    Signed-off-by: Dan Scott <dan at coffeecode.net>
    
    Conflicts:
    	Open-ILS/src/extras/Makefile.install
    
    Conflicts:
    	Open-ILS/src/extras/Makefile.install

diff --git a/Open-ILS/src/extras/Makefile.install b/Open-ILS/src/extras/Makefile.install
index b3a0953..414cb57 100644
--- a/Open-ILS/src/extras/Makefile.install
+++ b/Open-ILS/src/extras/Makefile.install
@@ -248,16 +248,14 @@ CPAN_MODULES_FORCE = \
 	Class::DBI::Frozen::301
 
 # Lucid Lynx needs the following additional CPAN modules.
-CPAN_MODULES_LUCID = \
-    RPC::XML::Function
+CPAN_MODULES_LUCID = 
 
 # Precise Pangolin needs the following CPAN modules. All others are
 # avaialalbe as debs.
 CPAN_MODULES_PRECISE = \
     Business::CreditCard::Object \
     Business::OnlinePayment::PayPal \
-    Template::Plugin::POSIX \
-    RPC::XML::Function
+    Template::Plugin::POSIX
 
 # ----------------------------------------------------------------------------
 
diff --git a/Open-ILS/src/perlmods/Build.PL b/Open-ILS/src/perlmods/Build.PL
index 00b0a26..0906965 100644
--- a/Open-ILS/src/perlmods/Build.PL
+++ b/Open-ILS/src/perlmods/Build.PL
@@ -69,7 +69,6 @@ my $build = Module::Build->new(
         'POSIX' => '0',
         'RPC::XML' => '0',
         'RPC::XML::Client' => '0',
-        'RPC::XML::Function' => '0',
         'RPC::XML::Method' => '0',
         'RPC::XML::Parser' => '0',
         'RPC::XML::Procedure' => '0',
diff --git a/Open-ILS/src/perlmods/lib/OpenILS/WWW/XMLRPCGateway.pm b/Open-ILS/src/perlmods/lib/OpenILS/WWW/XMLRPCGateway.pm
index 554c1af..42b69f6 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/WWW/XMLRPCGateway.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/WWW/XMLRPCGateway.pm
@@ -20,7 +20,6 @@ use OpenSRF::Utils::SettingsClient;
 
 use RPC::XML qw/smart_encode/;
 use RPC::XML::Parser;
-use RPC::XML::Function;
 use RPC::XML::Method;
 use RPC::XML::Procedure;
 

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/src/extras/Makefile.install               |    6 ++----
 Open-ILS/src/perlmods/Build.PL                     |    2 --
 .../src/perlmods/lib/OpenILS/WWW/XMLRPCGateway.pm  |    7 +++++--
 3 files changed, 7 insertions(+), 8 deletions(-)


hooks/post-receive
-- 
Evergreen ILS