[open-ils-commits] [GIT] Evergreen ILS branch rel_2_3 updated. eb0b61fc74a27035237250e8b758ed2d33903d57

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_2_3 has been updated
       via  eb0b61fc74a27035237250e8b758ed2d33903d57 (commit)
      from  d6b8a74cfb51bbf84fc2e1d2906d018ccf598f30 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit eb0b61fc74a27035237250e8b758ed2d33903d57
Author: Steven Chan <schan at sitka.bclibraries.ca>
Date:   Thu May 23 15:22:15 2013 -0700

    Patron Editor can enter erroneous values for Claims-returned count
    
    In the staff client, Patrons interface, Edit screen, when
    mouse-scrolling up and down the Edit form, it is possible to
    inadvertently change the value in Claims-returned Count or Claims Never
    Checked Out Count field.  It will happen if the mouse hovers over either
    data field while using the mouse wheel.
    
    Both data fields use the dijit.form.NumberSpinner widget to provide a
    'spin' behaviour.  The fix involves cancelling the mouse scroll event as
    it propagates to input fields in table rows that are using the
    dijit.form.NumberSpinner widget, because the mouse scroll would be
    applied too early by the widget, before the user has intentionally
    focussed on one of the input fields.  Now, mouse scrolling has no effect
    on the two input fields; it will only have an effect in scrolling the
    page up or down.
    
    Signed-off-by: Steven Chan <schan at sitka.bclibraries.ca>
    Signed-off-by: Ben Shum <bshum at biblio.org>

diff --git a/Open-ILS/web/js/ui/default/actor/user/register.js b/Open-ILS/web/js/ui/default/actor/user/register.js
index eee5569..0aa8474 100644
--- a/Open-ILS/web/js/ui/default/actor/user/register.js
+++ b/Open-ILS/web/js/ui/default/actor/user/register.js
@@ -296,6 +296,17 @@ function load() {
     }
         
     uUpdateContactInvalidators();
+
+    // Cancel mouse scroll events from propagating to table rows which are
+    // using the dijit.form.NumberSpinner widget, because the mouse scroll
+    // would be applied too early by the widget, before the user has
+    // intentionally focussed on the input field.
+    dojo.query('tr[wclass="dijit.form.NumberSpinner"]').forEach(function (tr) {
+        tr.addEventListener('DOMMouseScroll', function (ev) {
+            ev.stopPropagation();
+        }, true);
+    });
+
     lock_ready = true;
 }
 

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/web/js/ui/default/actor/user/register.js |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)


hooks/post-receive
-- 
Evergreen ILS