[open-ils-commits] [GIT] Evergreen ILS branch rel_2_4 updated. 514f5db19fe344bd2dde184a8c96f875ec2e1b88

Evergreen Git git at git.evergreen-ils.org
Wed Jul 17 13:38:40 EDT 2013


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_2_4 has been updated
       via  514f5db19fe344bd2dde184a8c96f875ec2e1b88 (commit)
      from  17a520e09079ebb66fceb86870614696c3a6ca35 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 514f5db19fe344bd2dde184a8c96f875ec2e1b88
Author: Dan Scott <dscott at laurentian.ca>
Date:   Mon Jun 24 10:12:50 2013 -0400

    Avoid Z39.50 search warning for uninit var
    
    The debug log blindly attempts to access list members that might not
    exist (if, for example, an event code was returned from the attempt to
    run do_service_search()), thus generating spurious log warnings.
    Instead, move the debug line to only generate output when we have
    created the list item in question.
    
    Signed-off-by: Dan Scott <dscott at laurentian.ca>
    Signed-off-by: Mike Rylander <mrylander at gmail.com>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Search/Z3950.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Search/Z3950.pm
index 1f17a0c..2fa73ff 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Search/Z3950.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Search/Z3950.pm
@@ -274,10 +274,11 @@ sub do_class_search {
                 push @services, $tmp_args{service}; 
                 push @results, $res->{result}; 
                 push @connections, $res->{connection}; 
+
+                $logger->debug("z3950: Result object: $results[$i], Connection object: $connections[$i]");
             } 
         }
 
-        $logger->debug("z3950: Result object: $results[$i], Connection object: $connections[$i]");
     }
 
     $logger->debug("z3950: Connections created");

-----------------------------------------------------------------------

Summary of changes:
 .../lib/OpenILS/Application/Search/Z3950.pm        |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
Evergreen ILS


More information about the open-ils-commits mailing list