[open-ils-commits] [GIT] Evergreen ILS branch rel_2_3 updated. 33b496412b5f2f49a096c54160aa2ed39b33af6f

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_2_3 has been updated
       via  33b496412b5f2f49a096c54160aa2ed39b33af6f (commit)
      from  deba8502795145d5272b21015e6d0e383db91f1b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 33b496412b5f2f49a096c54160aa2ed39b33af6f
Author: Lebbeous Fogle-Weekley <lebbeous at esilibrary.com>
Date:   Mon Apr 15 14:06:54 2013 -0400

    Acq: Be fuzzy about case when retrieving EDI documents
    
    The edi_fetcher relies on a routine in OpenILS::Acq::EDI to, among
    other things, try to avoid fetching the same EDI document multiple times
    when many rows in acq.edi_account refer to the same host and login
    credentials.
    
    Since in practice most vendors seem to run FTP servers for EDI on
    Windows, not UNIX, and pathnames are therefore case-insensitive, that
    test for other occurrences ought also to be case-insensitive.
    
    If I were to look at this as a purist, I could argue that vendor servers
    might sometimes by run on UNIX, and that for some reason it is possible
    that different vendor-to-buyer EDI documents (order responses or
    invoices) could have pathnames that differ only in the case of some
    characters.  But that seems wildly unlikely.  If anyone does take this
    possibility seriously, perhaps acq.edi_account needs a Boolean column to
    indicate the remote host's case [in]sensitivity.
    
    Signed-off-by: Lebbeous Fogle-Weekley <lebbeous at esilibrary.com>
    Signed-off-by: Ben Shum <bshum at biblio.org>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Acq/EDI.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Acq/EDI.pm
index a84b1c3..924787a 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Acq/EDI.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Acq/EDI.pm
@@ -135,7 +135,7 @@ sub retrieve_core {
                             password => $account->password,
                             in_dir => $account->in_dir
                         },
-                        remote_file => $remote_file,
+                        remote_file => {ilike => $remote_file},
                         status      => {'in' => [qw/ processed /]},
                     },
                     { join => {"acqedi" => {}}, limit => 1 }

-----------------------------------------------------------------------

Summary of changes:
 .../perlmods/lib/OpenILS/Application/Acq/EDI.pm    |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
Evergreen ILS