[open-ils-commits] [GIT] Evergreen ILS branch master updated. 418bbfa33aecb0bdbc118d2162ae6b7e3c2b8d8b

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  418bbfa33aecb0bdbc118d2162ae6b7e3c2b8d8b (commit)
      from  7a42d7f7f57ca885532c24b285f6375fb3338973 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 418bbfa33aecb0bdbc118d2162ae6b7e3c2b8d8b
Author: Bill Erickson <berick at esilibrary.com>
Date:   Fri Apr 5 13:28:08 2013 -0400

    Repair SIP start/end list ranges
    
    SIP supports paging of certain lists (holds, fines, etc.) by allowing
    the SIP client to provide start and end points for lists.  This patch
    repairs how Evgreen extracts the list ranges from arrays.
    
    When using Perl array ranges, the array variable should be accessed via
    '@' and not '$'.  Prior to this change, all ranged lists resulted in
    returning the first item in the list instead of the full range.
    
    This change affects lists of holds, overdues, fines, and charges.
    
    Signed-off-by: Bill Erickson <berick at esilibrary.com>
    Signed-off-by: Jeff Godin <jgodin at tadl.org>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/SIP/Patron.pm b/Open-ILS/src/perlmods/lib/OpenILS/SIP/Patron.pm
index d40be97..a3b0f85 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/SIP/Patron.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/SIP/Patron.pm
@@ -467,7 +467,7 @@ sub hold_items {
     push( @holds, OpenILS::SIP::clean_text($self->__hold_to_title($_)) ) for @$holds;
 
     return (defined $start and defined $end) ? 
-        [ $holds[($start-1)..($end-1)] ] : 
+        [ @holds[($start-1)..($end-1)] ] :
         \@holds;
 }
 
@@ -574,7 +574,7 @@ sub overdue_items {
     @overdues = @o;
 
     return (defined $start and defined $end) ? 
-        [ $overdues[($start-1)..($end-1)] ] : \@overdues;
+        [ @overdues[($start-1)..($end-1)] ] : \@overdues;
 }
 
 sub __circ_to_barcode {
@@ -623,7 +623,7 @@ sub charged_items {
     @charges = @c;
 
     return (defined $start and defined $end) ? 
-        [ $charges[($start-1)..($end-1)] ] : 
+        [ @charges[($start-1)..($end-1)] ] :
         \@charges;
 }
 
@@ -646,7 +646,7 @@ sub fine_items {
     my $log_status = $@ ? 'ERROR: ' . $@ : 'OK';
     syslog('LOG_DEBUG', 'OILS: Patron->fine_items() ' . $log_status);
     return (defined $start and defined $end) ? 
-        [ $fines[($start-1)..($end-1)] ] : \@fines;
+        [ @fines[($start-1)..($end-1)] ] : \@fines;
 }
 
 # not currently supported

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/src/perlmods/lib/OpenILS/SIP/Patron.pm |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)


hooks/post-receive
-- 
Evergreen ILS