[open-ils-commits] [GIT] Evergreen ILS branch rel_2_4 updated. 60ecc4bef9ab30bd10a6729846d4914b6255d05c

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_2_4 has been updated
       via  60ecc4bef9ab30bd10a6729846d4914b6255d05c (commit)
      from  a8971b7ff2fe313ca22f5439e422c061684cb187 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 60ecc4bef9ab30bd10a6729846d4914b6255d05c
Author: Dan Scott <dscott at laurentian.ca>
Date:   Thu Jun 20 23:11:20 2013 -0400

    Silence uninit var warnings from query normalizer
    
    $field_info can return undef from the search for a matching ID from the
    list of normalizers, which in turn generates several uninit var warnings
    when attempts are made to access members of the undef variable. We saw
    6700 occurrences of these warnings during a typical day of operations.
    
    Signed-off-by: Dan Scott <dscott at laurentian.ca>
    Signed-off-by: Bill Erickson <berick at esilibrary.com>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg/QueryParser.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg/QueryParser.pm
index 4fcbe5e..c41f163 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg/QueryParser.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Driver/Pg/QueryParser.pm
@@ -415,6 +415,7 @@ sub initialize_query_normalizers {
 
     for my $cmfinm ( @$tree ) {
         my $field_info = $self->search_field_class_by_id( $cmfinm->field );
+        next unless $field_info;
         __PACKAGE__->add_query_normalizer( $field_info->{classname}, $field_info->{field}, $cmfinm->norm->func, OpenSRF::Utils::JSON->JSON2perl($cmfinm->params) );
     }
 }

-----------------------------------------------------------------------

Summary of changes:
 .../Application/Storage/Driver/Pg/QueryParser.pm   |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)


hooks/post-receive
-- 
Evergreen ILS