[open-ils-commits] [GIT] Evergreen ILS branch master updated. d54eed44b4bd4db503c8dd032dfe5c3559dc441a

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  d54eed44b4bd4db503c8dd032dfe5c3559dc441a (commit)
      from  e99fda5591a608b85276c221302ce1c416093259 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit d54eed44b4bd4db503c8dd032dfe5c3559dc441a
Author: Bill Erickson <berick at esilibrary.com>
Date:   Wed Dec 26 10:29:30 2012 -0500

    Return calculated value for SIP recall_ok test
    
    Determine the value for the "recall OK" testing for patron information
    requests the same we we determine the value for ciruclations and holds.
    Previously, the recall-OK test always returned false, presumably since
    recalls are not currently supported in Evergreen SIP.
    
    Note that like holds and circs, we determine whether a user has good
    standing based on the users penalties and whether the user is active /
    non-barred.  Though we could in some cases, we are not checking whether
    the user has the required permission to perform specific tasks.
    
    This feature is enabled via a new oils_sip.xml configuration option:
    
    <option name='patron_calculate_recal_ok' value='true' />
    
    This option is disabled by default.
    
    Signed-off-by: Bill Erickson <berick at esilibrary.com>
    Signed-off-by: Mike Rylander <mrylander at gmail.com>

diff --git a/Open-ILS/examples/oils_sip.xml.example b/Open-ILS/examples/oils_sip.xml.example
index 8a1d7ab..d6c5d88 100644
--- a/Open-ILS/examples/oils_sip.xml.example
+++ b/Open-ILS/examples/oils_sip.xml.example
@@ -111,6 +111,13 @@
                         use the SIP date format.
                     <option name='use_sip_date_format' value='true' />
                     -->
+
+					<!--
+						If enabled, return the calculated value for the recall
+						flag instead of always returning not-OK
+					<option name='patron_calculate_recal_ok' value='true' />
+					-->
+
 				</options>
 
                 <checkin_override>
diff --git a/Open-ILS/src/perlmods/lib/OpenILS/SIP/Patron.pm b/Open-ILS/src/perlmods/lib/OpenILS/SIP/Patron.pm
index 4a77bd0..5ce70e9 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/SIP/Patron.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/SIP/Patron.pm
@@ -325,6 +325,8 @@ sub renew_ok {
 
 sub recall_ok {
     my $self = shift;
+    return $self->charge_ok if 
+        OpenILS::SIP->get_option_value('patron_calculate_recal_ok');
     return 0;
 }
 

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/examples/oils_sip.xml.example          |    7 +++++++
 Open-ILS/src/perlmods/lib/OpenILS/SIP/Patron.pm |    2 ++
 2 files changed, 9 insertions(+), 0 deletions(-)


hooks/post-receive
-- 
Evergreen ILS