[open-ils-commits] [GIT] Evergreen ILS branch master updated. cfa27b748346feadaca2c901ea2f56ab8d95f663

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  cfa27b748346feadaca2c901ea2f56ab8d95f663 (commit)
      from  35917a63499c38032ef680c18c438555c5f408f1 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit cfa27b748346feadaca2c901ea2f56ab8d95f663
Author: Jeff Godin <jgodin at tadl.org>
Date:   Thu Mar 14 14:15:28 2013 -0400

    Fix detection of empty Syndetics AC data elements
    
    Due to a change in how the vendor responds to requests for data
    elements which are not present for a requested title, we need to
    change how we detect "empty" data elements in the "data_exists"
    function.
    
    First, we check for the new "No Data Available" title element, then
    we check for the previously-used value of "error".
    
    This change resolves the symptom where the catalog would display
    tabs for "Author Notes", "Excerpt", "Table of Contents", on every
    record in the catalog, even when clicking each tab would show that
    the content was not present / available.
    
    Signed-off-by: Jeff Godin <jgodin at tadl.org>
    Signed-off-by: Ben Shum <bshum at biblio.org>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/WWW/AddedContent/Syndetic.pm b/Open-ILS/src/perlmods/lib/OpenILS/WWW/AddedContent/Syndetic.pm
index 9eff0ae..73d13a4 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/WWW/AddedContent/Syndetic.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/WWW/AddedContent/Syndetic.pm
@@ -214,6 +214,7 @@ sub summary_json {
 
 sub data_exists {
     my( $self, $data ) = @_;
+    return 0 if $data =~ m/<title>No Data Available<\/title>/iog;
     return 0 if $data =~ m/<title>error<\/title>/iog;
     return 1;
 }

-----------------------------------------------------------------------

Summary of changes:
 .../lib/OpenILS/WWW/AddedContent/Syndetic.pm       |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)


hooks/post-receive
-- 
Evergreen ILS