[open-ils-commits] [GIT] Evergreen ILS branch master updated. aebfcb20799b9893723aadee121d5b3f3f4b4c89

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  aebfcb20799b9893723aadee121d5b3f3f4b4c89 (commit)
      from  bfd6f7871e608b39bb40bd768ff4fff480ac1120 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit aebfcb20799b9893723aadee121d5b3f3f4b4c89
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Tue Mar 26 11:20:18 2013 -0400

    LP#1160343: remove unused open-ils.circ settings
    
    The circ_modifier and billing_types lists in the
    open-ils.circ section of opensrf.xml are no longer
    used.  This commit removes them from the opensrf.xml
    example config.  It also removes the method
    open-ils.circ.billing_type.retrieve.all, which has
    not be used by any other code once in-DB billing types
    were introduced.
    
    Any external clients that used the method that was
    removed should instead use
    open-ils.circ.billing_type.ranged.retrieve.all.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    Signed-off-by: Bill Erickson <berick at esilibrary.com>

diff --git a/Open-ILS/examples/opensrf.xml.example b/Open-ILS/examples/opensrf.xml.example
index 91243b1..7e69ff4 100644
--- a/Open-ILS/examples/opensrf.xml.example
+++ b/Open-ILS/examples/opensrf.xml.example
@@ -816,64 +816,6 @@ vim:et:ts=4:sw=4:
                         <circ_permit_hold>circ/circ_permit_hold.js</circ_permit_hold>
                     </scripts>               
 
-                    <circ_modifiers>
-                        <mod>art</mod>
-                        <mod>atlas</mod>
-                        <mod>audiobook</mod>
-                        <mod>av</mod>
-                        <mod>new-av</mod>
-                        <mod>bestseller</mod>
-                        <mod>bestsellernh</mod>
-                        <mod>book</mod>
-                        <mod>cd</mod>
-                        <mod>dvd</mod>
-                        <mod>dvd-long</mod>
-                        <mod>e-book</mod>
-                        <mod>equipment</mod>
-                        <mod>filmstrip</mod>
-                        <mod>kit</mod>
-                        <mod>magazine</mod>
-                        <mod>map</mod>
-                        <mod>microform</mod>
-                        <mod>music</mod>
-                        <mod>record</mod>
-                        <mod>software</mod>
-                        <mod>softwrlong</mod>
-                        <mod>equip-long</mod>
-                        <mod>talking book</mod>
-                        <mod>toy</mod>
-                        <mod>video</mod>
-                        <mod>video-long</mod>
-                    </circ_modifiers>
-
-                    <billing_types>
-                        <type>Miscellaneous</type>
-                        <type>Overdue materials</type>
-                        <type>Fee for placing a hold</type>
-                        <type>Fee for checking out a book</type>
-                        <type>Fee for library card</type>
-                        <type>Miscellaneous charges</type>
-                        <type>Lost materials</type>
-                        <type>Damaged material</type>
-                        <type>Overdue Reserves charge</type>
-                        <type>Recall overdue</type>
-                        <type>Fee for processing lost library materials</type>
-                        <type>Fee for sending patron bills to collection agency</type>
-                        <type>Fee for interlibrary loan</type>
-                        <type>Fee for copies</type>
-                        <type>Money advanced to pay for telephone use</type>
-                        <type>Deposit fee</type>
-                        <type>Fee for disk</type>
-                        <type>Fee for faxing</type>
-                        <type>Fee for laminating</type>
-                        <type>Fee for room cleaning</type>
-                        <type>Deposit returned; fee refund</type>
-                        <type>Sale items</type>
-                        <type>Fee for lost card</type>
-                        <type>Long overdue items</type>
-                        <type>Lost/Replacement Cassette</type>
-                        <type>Returned Check</type>
-                    </billing_types>
                 </app_settings>
             </open-ils.circ>
 
diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ.pm
index 5c2a754..5549fec 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ.pm
@@ -80,16 +80,6 @@ sub fetch_circ_mods {
 }
 
 __PACKAGE__->register_method(
-	method => 'fetch_bill_types',
-	api_name => 'open-ils.circ.billing_type.retrieve.all');
-sub fetch_bill_types {
-	my $conf = OpenSRF::Utils::SettingsClient->new;
-	return $conf->config_value(
-		'apps', 'open-ils.circ', 'app_settings', 'billing_types', 'type' );
-}
-
-
-__PACKAGE__->register_method(
     method => 'ranged_billing_types',
     api_name => 'open-ils.circ.billing_type.ranged.retrieve.all');
 

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/examples/opensrf.xml.example              |   58 --------------------
 .../src/perlmods/lib/OpenILS/Application/Circ.pm   |   10 ----
 2 files changed, 0 insertions(+), 68 deletions(-)


hooks/post-receive
-- 
Evergreen ILS