[open-ils-commits] [GIT] Evergreen ILS branch rel_2_4 updated. ff1df8ea5ca2598c84f1505309b5ceeee893a9df

Evergreen Git git at git.evergreen-ils.org
Thu Nov 14 16:24:47 EST 2013


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_2_4 has been updated
       via  ff1df8ea5ca2598c84f1505309b5ceeee893a9df (commit)
      from  4c178f7dcd9bdb7d148edcc94e83ecb2979ce663 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit ff1df8ea5ca2598c84f1505309b5ceeee893a9df
Author: Steven Callender <stevecallender at esilibrary.com>
Date:   Thu Nov 14 15:42:12 2013 -0500

    LP1251424 - Fix for submit button when placing holds in staff client
    
    I've moved the initializing of the cur_hold_barcode variable
    to within the function rather than floating outside of it.
    This seemed to fix an intermittent issue where the submit
    button would not become activatable when first going to the
    place hold screen via the staff client. To create the hold,
    ths user had to cycle through the "Place hold by patron barcode"
    option and then back to "Place hold for me" option.
    
    It looked like behind the scenes for certain org units that
    variable would not be set and the button will not open until
    it at least has something. This causes it to be set on the initial
    loading of the screen.
    
    Signed-off-by: Steven Callender <stevecallender at esilibrary.com>
    Signed-off-by: Ben Shum <bshum at biblio.org>

diff --git a/Open-ILS/web/js/ui/default/opac/staff.js b/Open-ILS/web/js/ui/default/opac/staff.js
index e5db008..2be839f 100644
--- a/Open-ILS/web/js/ui/default/opac/staff.js
+++ b/Open-ILS/web/js/ui/default/opac/staff.js
@@ -26,9 +26,9 @@ function no_hold_submit(event) {
     }
     return true;
 }
-var cur_hold_barcode = undefined;
 function staff_hold_usr_barcode_changed(isload) {
     if(typeof xulG != 'undefined' && xulG.get_barcode_and_settings) {
+        var cur_hold_barcode = undefined;
         var barcode = isload;
         if(!barcode || barcode === true) barcode = document.getElementById('staff_barcode').value;
         var only_settings = true;

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/web/js/ui/default/opac/staff.js |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
Evergreen ILS


More information about the open-ils-commits mailing list