[open-ils-commits] ***SPAM*** [GIT] Evergreen ILS branch master updated. 6c7591ab82d78135d968a82dbd14a4805763a857

Evergreen Git git at git.evergreen-ils.org
Mon Oct 14 15:59:34 EDT 2013


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  6c7591ab82d78135d968a82dbd14a4805763a857 (commit)
      from  d8278e3dfd7632f2a7b1165b9c6229297f7844de (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 6c7591ab82d78135d968a82dbd14a4805763a857
Author: Dan Wells <dbw2 at calvin.edu>
Date:   Mon Oct 14 15:24:39 2013 -0400

    Fix integrated subscription editor record field
    
    When trying to edit a subscription using the new 'integrated' editor,
    it foolishly tries to populate an unfiltered bre dropdown selector.
    This works OK in test environments, but (as expected) fails miserably
    with production-size data sets.
    
    The end result is that the dropdown either never populates, or takes
    a really long time.  If the user saves before the dropdown loads, the
    associated record ID is lost, and the subscription is no longer
    properly associated with the record.
    
    To fix this, simply turn the dropdown into a disabled text input
    instead, as the ability to edit this field would generally be more
    harmful than it is necessary.
    
    Signed-off-by: Dan Wells <dbw2 at calvin.edu>
    Signed-off-by: Lebbeous Fogle-Weekley <lebbeous at esilibrary.com>

diff --git a/Open-ILS/web/js/ui/default/serial/subscription.js b/Open-ILS/web/js/ui/default/serial/subscription.js
index bedb587..5860a56 100644
--- a/Open-ILS/web/js/ui/default/serial/subscription.js
+++ b/Open-ILS/web/js/ui/default/serial/subscription.js
@@ -334,6 +334,8 @@ openils.Util.addOnLoad(
                 }
 
                 ssub_grid.showCreateDialog();
+            } else {
+                ssub_grid.overrideWidgetArgs.record_entry = {widgetClass : "dijit.form.TextBox", dijitArgs : {disabled : true}};
             }
             ssub_grid.onPostUpdate = function(fmObject) {
                 parent.document.getElementById(window.name).refresh_command();

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/web/js/ui/default/serial/subscription.js |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)


hooks/post-receive
-- 
Evergreen ILS


More information about the open-ils-commits mailing list