[open-ils-commits] [GIT] Evergreen ILS branch master updated. 8b23255595364dcce3fb0b9dbef64f10959ad234

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  8b23255595364dcce3fb0b9dbef64f10959ad234 (commit)
       via  8c04afc9314039b3ec78082d25e18f6155ff28ff (commit)
      from  2943a99cacc7662d0a195bfe0aad2a0bb7228e5e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 8b23255595364dcce3fb0b9dbef64f10959ad234
Author: Dan Wells <dbw2 at calvin.edu>
Date:   Mon Sep 16 16:50:53 2013 -0400

    Move list delete check from onclick to onsubmit
    
    Cause Brendan Eich says it's better :)
    
    Signed-off-by: Dan Wells <dbw2 at calvin.edu>
    Signed-off-by: Remington Steed <rjs7 at calvin.edu>

diff --git a/Open-ILS/src/templates/opac/myopac/lists.tt2 b/Open-ILS/src/templates/opac/myopac/lists.tt2
index 8672c6e..ccfafb1 100644
--- a/Open-ILS/src/templates/opac/myopac/lists.tt2
+++ b/Open-ILS/src/templates/opac/myopac/lists.tt2
@@ -153,14 +153,12 @@
                     [% END %]
                 </div>
             </form>
-            <form action="[% mkurl(ctx.opac_root _ '/myopac/list/update') %]" method="post">
+            <form action="[% mkurl(ctx.opac_root _ '/myopac/list/update') %]" method="post" onsubmit="return confirm('[% l('Do you really want to delete this list?') %]')">
                 <div class="bookbag-controls">
                     <input type="hidden" name="list" value="[% bbag.id %]" />
                     <input type="hidden" name="action" value="delete" />
                     [%- INCLUDE "opac/parts/preserve_params.tt2"; %]
-                    <input type="submit" value="[% l('Delete List') %]"
-                        onClick="if(confirm('[% l('Do you really want to delete this list?') %]')) return true; return false"
-                    />
+                    <input type="submit" value="[% l('Delete List') %]" />
                 </div>
             </form>
             <form action="[% mkurl(ctx.opac_root _ '/myopac/list/print') %]" method="post">

commit 8c04afc9314039b3ec78082d25e18f6155ff28ff
Author: Kyle Tomita <ktomita at catalystitservices.com>
Date:   Fri May 24 11:52:49 2013 -0700

    LP1164674 - OPAC - Too easy to delete a list
    
    Added an onClick action to prompt for confirmation before
    deleting a list.
    
    Signed-off-by: Kyle Tomita <ktomita at catalystitservices.com>
    Signed-off-by: Dan Wells <dbw2 at calvin.edu>

diff --git a/Open-ILS/src/templates/opac/myopac/lists.tt2 b/Open-ILS/src/templates/opac/myopac/lists.tt2
index 392a528..8672c6e 100644
--- a/Open-ILS/src/templates/opac/myopac/lists.tt2
+++ b/Open-ILS/src/templates/opac/myopac/lists.tt2
@@ -158,7 +158,9 @@
                     <input type="hidden" name="list" value="[% bbag.id %]" />
                     <input type="hidden" name="action" value="delete" />
                     [%- INCLUDE "opac/parts/preserve_params.tt2"; %]
-                    <input type="submit" value="[% l('Delete List') %]" />
+                    <input type="submit" value="[% l('Delete List') %]"
+                        onClick="if(confirm('[% l('Do you really want to delete this list?') %]')) return true; return false"
+                    />
                 </div>
             </form>
             <form action="[% mkurl(ctx.opac_root _ '/myopac/list/print') %]" method="post">

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/src/templates/opac/myopac/lists.tt2 |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
Evergreen ILS