[open-ils-commits] ***SPAM*** [GIT] Evergreen ILS branch master updated. 3282cbbac2bc04fcf5beebffcffaebb3ce72b956

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  3282cbbac2bc04fcf5beebffcffaebb3ce72b956 (commit)
      from  954bb310efd5ee54d819ae85ad18c3bc1fab8e22 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 3282cbbac2bc04fcf5beebffcffaebb3ce72b956
Author: Lebbeous Fogle-Weekley <lebbeous at esilibrary.com>
Date:   Thu Sep 5 13:24:54 2013 -0400

    Better handling of purchase_order being non-numeric
    
    Signed-off-by: Lebbeous Fogle-Weekley <lebbeous at esilibrary.com>
    Signed-off-by: Ben Shum <bshum at biblio.org>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Acq/EDI.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Acq/EDI.pm
index 70642bd..a7b05a4 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Acq/EDI.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Acq/EDI.pm
@@ -224,8 +224,8 @@ sub process_retrieval {
             # up PO number later from the lineitems themselves if necessary.
 
             if ($msg_hash->{purchase_order} !~ /^\d+$/) {
-                $logger->warn("EDI: PO identifier is non-numeric. Continuing.");
-                # No "next" here; we'll process this and just not link to acqpo.
+                $logger->warn("EDI: PO identifier is non-numeric. Blanking and continuing.");
+                undef $msg_hash->{purchase_order};
             } else {
                 $logger->info("EDI: processing message for PO " .
                     $msg_hash->{purchase_order});
@@ -898,6 +898,7 @@ sub invoice_lineitem_to_invoice_entry {
 # references from the electronic invoice.
 # @param    $message            An acqedim object
 # @param    $invoice_lineitems  An arrayref from part of EDIReader output
+# NOTE: This sub can have side-effects on $message.
 sub process_invoice_lineitems {
     my ($e, $msg_kludges, $log_prefix, $message, $invoice_lineitems) = @_;
 

-----------------------------------------------------------------------

Summary of changes:
 .../perlmods/lib/OpenILS/Application/Acq/EDI.pm    |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
Evergreen ILS