[open-ils-commits] ***SPAM*** [GIT] Evergreen ILS branch rel_2_5 updated. 6a208fccd3cc6ecf1838acda03bc9f7723b4ed9c

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_2_5 has been updated
       via  6a208fccd3cc6ecf1838acda03bc9f7723b4ed9c (commit)
      from  52b5b742fc4bfd984decb269fcda21ca787e96af (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 6a208fccd3cc6ecf1838acda03bc9f7723b4ed9c
Author: Thomas Berezansky <tsbere at mvlc.org>
Date:   Thu Jun 21 11:38:39 2012 -0400

    Assume that future checkins are junk input
    
    This can happen with SIP2 clients with badly set clocks.
    
    Signed-off-by: Thomas Berezansky <tsbere at mvlc.org>
    Signed-off-by: Ben Shum <bshum at biblio.org>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm
index b390688..5f73860 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm
@@ -3637,7 +3637,12 @@ sub checkin_handle_backdate {
     my $new_date = DateTime::Format::ISO8601->new->parse_datetime($bd);
     $new_date->set_hour($original_date->hour());
     $new_date->set_minute($original_date->minute());
-    $bd = cleanse_ISO8601($new_date->datetime());
+    if ($new_date >= DateTime->now) {
+        # We can't say that the item will be checked in later...so assume someone's clock is wrong instead.
+        $bd = undef;
+    } else {
+        $bd = cleanse_ISO8601($new_date->datetime());
+    }
 
     $self->backdate($bd);
     return undef;

-----------------------------------------------------------------------

Summary of changes:
 .../lib/OpenILS/Application/Circ/Circulate.pm      |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
Evergreen ILS