[open-ils-commits] [GIT] Evergreen ILS branch master updated. ddbf7fc70d05d08c1fdceade812f9a26bc33d91a

Evergreen Git git at git.evergreen-ils.org
Mon Feb 17 15:50:25 EST 2014


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  ddbf7fc70d05d08c1fdceade812f9a26bc33d91a (commit)
      from  be5803f14b193e0f39b50731624c6206baa08bb1 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit ddbf7fc70d05d08c1fdceade812f9a26bc33d91a
Author: Ben Shum <bshum at biblio.org>
Date:   Sat Feb 8 03:42:07 2014 -0500

    LP1125471 - Use label instead of id in recording in-house use prompt
    
    When recording multiple in-house use with the library settings for threshold
    prompts, the prompt would bring up the ID as the variable instead of the name
    of the non-cataloged material. This caused confusion among staff members who
    might see a message like: "Are you sure you want to mark 9 as having been used
    21 times?" (9 being the id, not the name of the non-cataloged material)
    
    This commit leverages existing code which had been commented out and under
    the ID to use the label name for the non-cataloged material instead. Also,
    minor bugfix with a missing semi-colon at the end of the function being used.
    
    Signed-off-by: Ben Shum <bshum at biblio.org>
    Signed-off-by: Bill Erickson <berick at esilibrary.com>

diff --git a/Open-ILS/xul/staff_client/server/circ/in_house_use.js b/Open-ILS/xul/staff_client/server/circ/in_house_use.js
index e3d7be5..2287448 100644
--- a/Open-ILS/xul/staff_client/server/circ/in_house_use.js
+++ b/Open-ILS/xul/staff_client/server/circ/in_house_use.js
@@ -229,8 +229,7 @@ circ.in_house_use.prototype = {
                     if ( obj.test_barcode(barcode) ) { /* good */ } else { /* bad */ return; }
                 }
             } else {
-                barcode = ( obj.controller.view.in_house_use_menu.value );
-                //barcode = obj.data.hash.cnct[ obj.controller.view.in_house_use_menu.value ].name()
+                barcode = obj.data.hash.cnct[ obj.controller.view.in_house_use_menu.value ].name();
             }
             var multiplier = Number( obj.controller.view.in_house_use_multiplier_textbox.value );
 

-----------------------------------------------------------------------

Summary of changes:
 .../xul/staff_client/server/circ/in_house_use.js   |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
Evergreen ILS


More information about the open-ils-commits mailing list