[open-ils-commits] ***SPAM*** [GIT] Evergreen ILS branch rel_2_4 updated. df48a860b50af34562b8a728a60b789de62f5004

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_2_4 has been updated
       via  df48a860b50af34562b8a728a60b789de62f5004 (commit)
      from  53d46678e79d6769572a5bca312b123cbc142ad5 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit df48a860b50af34562b8a728a60b789de62f5004
Author: Jeff Godin <jgodin at tadl.org>
Date:   Wed Oct 30 15:29:24 2013 -0400

    Treat empty username as invalid in user editor
    
    There seems to be undesired interaction between the required
    attribute and the isValid method on a dojo/dijit ValidationTextBox.
    If both are set, isValid needs to check for an empty value,
    otherwise the field is considered valid the moment it gains focus.
    
    We don't want an empty username to be considered valid, because we
    know that we will be unable to save the user.
    
    We can work around this by teaching the isValid function to consider
    an empty value as invalid.
    
    Signed-off-by: Jeff Godin <jgodin at tadl.org>
    Signed-off-by: Melissa Ceraso <mceraso at biblio.org>
    Signed-off-by: Ben Shum <bshum at biblio.org>

diff --git a/Open-ILS/web/js/ui/default/actor/user/register.js b/Open-ILS/web/js/ui/default/actor/user/register.js
index 0aa8474..832d973 100644
--- a/Open-ILS/web/js/ui/default/actor/user/register.js
+++ b/Open-ILS/web/js/ui/default/actor/user/register.js
@@ -1283,6 +1283,10 @@ function attachWidgetEvents(fmcls, fmfield, widget) {
 
             case 'usrname':
                 widget.widget.isValid = function() {
+                    // Not empty
+                    if(this.attr("value") == '') {
+                        return false;
+                    }
                     // No spaces
                     if(this.attr("value").match(/\s/)) {
                         return false;

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/web/js/ui/default/actor/user/register.js |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)


hooks/post-receive
-- 
Evergreen ILS