[open-ils-commits] ***SPAM*** [GIT] Evergreen ILS branch master updated. e46f3323b4acb152d666b92c0ba5f4442b9ac2c0

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  e46f3323b4acb152d666b92c0ba5f4442b9ac2c0 (commit)
      from  8f4d3efb029f109d3dc7dc69cf458c2834c725d6 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit e46f3323b4acb152d666b92c0ba5f4442b9ac2c0
Author: Bill Erickson <berick at esilibrary.com>
Date:   Tue Jul 29 15:11:44 2014 -0400

    LP#1308239 precat holds fulfillment logic repair
    
    In cases where there is no hold on a precat copy, avoid trying to find
    "related" holds, in part because it's unnecessary, but also because the
    implementation assumes a fleshed $self->volume object, which is not
    present during precat checkout.
    
    Signed-off-by: Bill Erickson <berick at esilibrary.com>
    Signed-off-by: Jason Stephenson <jstephenson at mvlc.org>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm
index 896102d..f37c0fb 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Circulate.pm
@@ -1792,7 +1792,9 @@ sub find_related_user_hold {
     my($self, $copy, $patron) = @_;
     my $e = $self->editor;
 
-    return undef if $self->volume->id == OILS_PRECAT_CALL_NUMBER; 
+    # holds on precat copies are always copy-level, so this call will
+    # always return undef.  Exit early.
+    return undef if $self->is_precat;
 
     return undef unless $U->ou_ancestor_setting_value(        
         $self->circ_lib, 'circ.checkout_fills_related_hold', $e);

-----------------------------------------------------------------------

Summary of changes:
 .../lib/OpenILS/Application/Circ/Circulate.pm      |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
Evergreen ILS