[open-ils-commits] ***SPAM*** [GIT] Evergreen ILS branch rel_2_6 updated. bd523b6656b9fa97e159c713b17e5e624b39ee3a
Evergreen Git
git at git.evergreen-ils.org
Thu Jun 26 15:52:43 EDT 2014
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".
The branch, rel_2_6 has been updated
via bd523b6656b9fa97e159c713b17e5e624b39ee3a (commit)
via 3fe380f4d04a3d721999a3415f420b31acc49e87 (commit)
via dfa8abafeb1d1fef9bb62ca4f9d665c6bff1cdc2 (commit)
via b48ffc96c7f171aa2c237a4e028bd4e62c25421a (commit)
via 63eefc51fdd48fab8dace6f7e3456ddd5d3d89cf (commit)
via ac298183bdbdcc5b77af15caeec20b14662213ac (commit)
via e0123927d816b4aeb269f5088939724a5ca8b64c (commit)
from b4714bcb59ffc1b2a867803576266326597368f7 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit bd523b6656b9fa97e159c713b17e5e624b39ee3a
Author: Bill Erickson <berick at esilibrary.com>
Date: Fri May 30 12:55:47 2014 -0400
LP#1301599 Remove duplicate title attributes
Thanks to Ben Shum for spotting these!
Signed-off-by: Bill Erickson <berick at esilibrary.com>
Signed-off-by: Ben Shum <bshum at biblio.org>
diff --git a/Open-ILS/src/templates/opac/myopac/holds.tt2 b/Open-ILS/src/templates/opac/myopac/holds.tt2
index de5fcbd..08ebfce 100644
--- a/Open-ILS/src/templates/opac/myopac/holds.tt2
+++ b/Open-ILS/src/templates/opac/myopac/holds.tt2
@@ -59,7 +59,6 @@
<tr>
<td>
<select name="action" id="acct_holds_actions"
- title="[% l('Select your action for the selected holds') %]"
title="[% l('Select your action for the selected holds') %]">
<option id='myopac_holds_actions_none' value=''>
-- [% l("Actions for selected holds") %] --
diff --git a/Open-ILS/src/templates/opac/parts/myopac/prefs_base.tt2 b/Open-ILS/src/templates/opac/parts/myopac/prefs_base.tt2
index a9e52b7..c8c26f0 100644
--- a/Open-ILS/src/templates/opac/parts/myopac/prefs_base.tt2
+++ b/Open-ILS/src/templates/opac/parts/myopac/prefs_base.tt2
@@ -40,8 +40,7 @@
<div id="acct_prefs_select">
<form name="acct_prefs_nav">
<select name="acct_prefs_url"
- [% select_title = l('Select a preference page') %]
- title="[% select_title %]" title="[% select_title %]"
+ title="[% l('Select a preference page') %]"
onchange="window.location.href=document.acct_prefs_nav.acct_prefs_url.options[document.acct_prefs_nav.acct_prefs_url.selectedIndex].value">
[% FOREACH page IN acct_prefs_pages;
IF page.url != prefs_page; -%]
commit 3fe380f4d04a3d721999a3415f420b31acc49e87
Author: Bill Erickson <berick at esilibrary.com>
Date: Thu Apr 10 16:59:14 2014 -0400
LP#1301599 Additional TPAC facets structure markup
Labeling facets with <h4> tags provides additional page structure for
screen readers in the TPAC results pages.
Signed-off-by: Bill Erickson <berick at esilibrary.com>
Signed-off-by: Ben Shum <bshum at biblio.org>
diff --git a/Open-ILS/src/templates/opac/css/style.css.tt2 b/Open-ILS/src/templates/opac/css/style.css.tt2
index 85367aa..84d5fa5 100644
--- a/Open-ILS/src/templates/opac/css/style.css.tt2
+++ b/Open-ILS/src/templates/opac/css/style.css.tt2
@@ -1048,6 +1048,13 @@ div#facet_sidebar {
padding-left:12px;
}
+/* in this context, where h4 is primarily for structure,
+ avoid the normal large font and margin for h4's */
+.facet_box_temp h4 {
+ font-size : 100%;
+ margin: 0px;
+}
+
.facet_box_temp .header a.button {
float:right;
padding-top:6px;
diff --git a/Open-ILS/src/templates/opac/parts/result/facets.tt2 b/Open-ILS/src/templates/opac/parts/result/facets.tt2
index c4adc08..82d2c6f 100644
--- a/Open-ILS/src/templates/opac/parts/result/facets.tt2
+++ b/Open-ILS/src/templates/opac/parts/result/facets.tt2
@@ -78,7 +78,7 @@ FOR facet IN sorted_facets;
[% l("More") %]
</a>
[% END %]
- <div class="title">[% facet.cmf.label %]</div>
+ <h4 class="title">[% facet.cmf.label %]</h4>
</div>
<div class="box_wrapper">
<div class="box">
commit dfa8abafeb1d1fef9bb62ca4f9d665c6bff1cdc2
Author: Bill Erickson <berick at esilibrary.com>
Date: Thu Apr 10 16:49:36 2014 -0400
LP#1301599 TPAC replace aria-label with title
As appropriate, replace aria-label attributes with traditional HTML
title attributes.
For ref, from the LP entry:
http://www.w3.org/TR/2013/WD-aria-in-html-20131003/#first-rule-of-aria-use
"If you can use a native HTML element [HTML5] or attribute with the
semantics and behaviour you require already built in, instead of
re-purposing an element and adding an ARIA role, state or property to
make it accessible, then do so."
Signed-off-by: Bill Erickson <berick at esilibrary.com>
Signed-off-by: Ben Shum <bshum at biblio.org>
diff --git a/Open-ILS/src/templates/opac/myopac/holds.tt2 b/Open-ILS/src/templates/opac/myopac/holds.tt2
index 8d049ea..de5fcbd 100644
--- a/Open-ILS/src/templates/opac/myopac/holds.tt2
+++ b/Open-ILS/src/templates/opac/myopac/holds.tt2
@@ -59,7 +59,7 @@
<tr>
<td>
<select name="action" id="acct_holds_actions"
- aria-label="[% l('Select your action for the selected holds') %]"
+ title="[% l('Select your action for the selected holds') %]"
title="[% l('Select your action for the selected holds') %]">
<option id='myopac_holds_actions_none' value=''>
-- [% l("Actions for selected holds") %] --
diff --git a/Open-ILS/src/templates/opac/parts/advanced/search.tt2 b/Open-ILS/src/templates/opac/parts/advanced/search.tt2
index f60d499..5242733 100644
--- a/Open-ILS/src/templates/opac/parts/advanced/search.tt2
+++ b/Open-ILS/src/templates/opac/parts/advanced/search.tt2
@@ -121,7 +121,7 @@
[% CASE "copy_location" %]
<select id="adv_copy_location_selector"
- aria-label="[% l('Select Shelving Location') %]"
+ title="[% l('Select Shelving Location') %]"
name="fi:locations" size="3" multiple="multiple">
</select>
[%
diff --git a/Open-ILS/src/templates/opac/parts/coded_value_selector.tt2 b/Open-ILS/src/templates/opac/parts/coded_value_selector.tt2
index 3c242f2..c8eb62e 100644
--- a/Open-ILS/src/templates/opac/parts/coded_value_selector.tt2
+++ b/Open-ILS/src/templates/opac/parts/coded_value_selector.tt2
@@ -19,7 +19,7 @@
<select id='[% id %]' name='[% name %]'[%
multiple ? ' multiple="multiple"' : '';
size ? (' size="' _ size _ '"') : '';
-%] aria-label="[% filter_label || l('Select item type:') %]">
+%] title="[% filter_label || l('Select item type:') %]">
[% IF none_ok %]
<option value=''>[% none_label ? none_label : l('-- Any --') %]</option>
[% END;
diff --git a/Open-ILS/src/templates/opac/parts/myopac/base.tt2 b/Open-ILS/src/templates/opac/parts/myopac/base.tt2
index 6fd5c9c..dfc7abf 100644
--- a/Open-ILS/src/templates/opac/parts/myopac/base.tt2
+++ b/Open-ILS/src/templates/opac/parts/myopac/base.tt2
@@ -34,7 +34,6 @@
<form name="acct_nav">
<select name="acct_url"
- aria-label="[% l('Select an account page') %]"
title="[% l('Select an account page') %]"
onchange="window.location.href=document.acct_nav.acct_url.options[document.acct_nav.acct_url.selectedIndex].value">
<option value="" selected="selected">[% l('Go to...') %]</option>
diff --git a/Open-ILS/src/templates/opac/parts/myopac/prefs_base.tt2 b/Open-ILS/src/templates/opac/parts/myopac/prefs_base.tt2
index cf38a62..a9e52b7 100644
--- a/Open-ILS/src/templates/opac/parts/myopac/prefs_base.tt2
+++ b/Open-ILS/src/templates/opac/parts/myopac/prefs_base.tt2
@@ -41,7 +41,7 @@
<form name="acct_prefs_nav">
<select name="acct_prefs_url"
[% select_title = l('Select a preference page') %]
- aria-label="[% select_title %]" title="[% select_title %]"
+ title="[% select_title %]" title="[% select_title %]"
onchange="window.location.href=document.acct_prefs_nav.acct_prefs_url.options[document.acct_prefs_nav.acct_prefs_url.selectedIndex].value">
[% FOREACH page IN acct_prefs_pages;
IF page.url != prefs_page; -%]
diff --git a/Open-ILS/src/templates/opac/parts/org_selector.tt2 b/Open-ILS/src/templates/opac/parts/org_selector.tt2
index 1b60855..ab4d7c9 100644
--- a/Open-ILS/src/templates/opac/parts/org_selector.tt2
+++ b/Open-ILS/src/templates/opac/parts/org_selector.tt2
@@ -28,8 +28,7 @@ BLOCK build_org_selector;
-%]
<select [% IF id %] id='[% id %]' [% END -%]
- [% IF arialabel %] aria-label='[% arialabel %]'
- [% ELSE %] title='[% l("Select Library") %]' [% END -%]
+ title='[% arialabel || l("Select Library") %]'
name='[% name %]'>
[%-
WHILE node_stack.size > 0;
diff --git a/Open-ILS/src/templates/opac/parts/qtype_selector.tt2 b/Open-ILS/src/templates/opac/parts/qtype_selector.tt2
index 6986fc1..1c8fc2c 100644
--- a/Open-ILS/src/templates/opac/parts/qtype_selector.tt2
+++ b/Open-ILS/src/templates/opac/parts/qtype_selector.tt2
@@ -8,7 +8,7 @@
{value => "id|bibcn", label => l("Bib Call Number")}
] %]
<select name="[% name || 'qtype' %]"[% IF id; ' id="'; id ; '"' ; END -%]
- aria-label="[% l('Select query type:') %]">
+ title="[% l('Select query type:') %]">
[% query_type = query_type || CGI.param('qtype') || search.default_qtypes.0;
FOR qt IN query_types;
NEXT IF browse_only AND NOT qt.browse -%]
commit b48ffc96c7f171aa2c237a4e028bd4e62c25421a
Author: Bill Erickson <berick at esilibrary.com>
Date: Thu Apr 3 14:53:36 2014 -0400
LP#1301599 TPAC add missing metabib filter label
In the quick search bar along the top.
Signed-off-by: Bill Erickson <berick at esilibrary.com>
Signed-off-by: Ben Shum <bshum at biblio.org>
diff --git a/Open-ILS/src/templates/opac/results.tt2 b/Open-ILS/src/templates/opac/results.tt2
index 8e6e3a1..1bd4d32 100644
--- a/Open-ILS/src/templates/opac/results.tt2
+++ b/Open-ILS/src/templates/opac/results.tt2
@@ -78,8 +78,9 @@
[% l('Limit to available items') %]
</label>
[% IF NOT metarecords.disabled %]
- <label class="results_header_lbl">
- <input type="checkbox" name="modifier" value="metabib"
+ <label class="results_header_lbl" for="metabib_search_modifier">
+ <input type="checkbox" id="metabib_search_modifier"
+ name="modifier" value="metabib"
onchange="search_modifier_onchange('metabib', this, true)"
[% CGI.param('modifier').grep('metabib').size ? ' checked="checked"' : '' %] />
[% l('Group Formats and Editions') %]
commit 63eefc51fdd48fab8dace6f7e3456ddd5d3d89cf
Author: Bill Erickson <berick at esilibrary.com>
Date: Thu Apr 3 13:31:29 2014 -0400
LP#1301599 TPAC advanced search from labels
Instead of using titles / aria-labels directly on advanced search
selectors, provide selector IDs so the existing text labels can be
turned into <labels> and linked (by id) to their form control.
This means we only need one label per form control, which improves
usability from an accessibility perspective.
Signed-off-by: Ben Shum <bshum at biblio.org>
diff --git a/Open-ILS/src/templates/opac/parts/advanced/search.tt2 b/Open-ILS/src/templates/opac/parts/advanced/search.tt2
index b6e5e3d..f60d499 100644
--- a/Open-ILS/src/templates/opac/parts/advanced/search.tt2
+++ b/Open-ILS/src/templates/opac/parts/advanced/search.tt2
@@ -7,7 +7,7 @@
<div id='adv_search_rows'>
<!-- Contains the user-addable(?) rows to define search class, containment and text -->
<div valign='top' class='adv_global_input_container'>
- <table id='adv_global_input_table'>
+ <table id='adv_global_input_table' role="presentation">
<thead>
<tr>
<td>
@@ -33,7 +33,7 @@
<div id='adv_search_submit'>
<input type="hidden" name="_adv" value="1" />
<span>
- <input id='search-submit-go' type="submit" value="[% l('Search') %]" alt="[% l('Search') %]" class="opac-button"
+ <input id='search-submit-go' type="submit" value="[% l('Search') %]" title="[% l('Search') %]" class="opac-button"
onclick='setTimeout(function(){$("search-submit-spinner").className=""; $("search-submit-go").className="hidden"}, 2000)'/>
<img id='search-submit-spinner' src='/opac/images/progressbar_green.gif'
class='hidden' alt="[% l('Search in progress icon') %]"/>
@@ -59,13 +59,14 @@
<div valign='top'[% IF adv_chunk.js_only %]
id='adv_chunk_[% adv_chunk.adv_special %]'
class='hidden'[% END %]>
- <strong>[% adv_chunk.adv_label %]</strong><br />
+ <strong><label for="[% adv_chunk.id %]">
+ [% adv_chunk.adv_label %] </label></strong><br />
[%
IF adv_chunk.adv_special;
SWITCH adv_chunk.adv_special;
CASE "lib_selector";
PROCESS "opac/parts/org_selector.tt2";
- INCLUDE build_org_selector show_loc_groups=1 id="adv_org_selector" %]
+ INCLUDE build_org_selector show_loc_groups=1 id=adv_chunk.id %]
<div class="adv_search_available">
<input type='checkbox' name="modifier"
value="available"[% CGI.param('modifier').grep('available').size ? ' checked="checked"' : '' %]
@@ -76,7 +77,7 @@
[%
CASE "pub_year"; %]
<select name='pubdate'
- title="[% l('Publicatiion date search modifier') %]"
+ id="[% adv_chunk.id %]"
onchange='if(this.selectedIndex == 3)
unHideMe($("adv_global_pub_date_2_span"));
else
@@ -91,16 +92,17 @@
</select>
<br/>
<div id='adv_special_block'>
- <input title="[% l('First date') %]"
+ <input title="[% l('Search date') %]"
name='date1' type='text' size='4' maxlength='4' value="[% CGI.param('date1') | html %]" />
<span id='adv_global_pub_date_2_span' class='[% CGI.param("pubdate") == "between" ? "" : "hide_me" %]'>
[% l("and") %] <input name='date2'
- title="[% l('Second date') %]" type='text' size='4' maxlength='4' value="[% CGI.param('date2') | html %]" />
+ title="[% l('Secondary search date') %]" type='text' size='4' maxlength='4' value="[% CGI.param('date2') | html %]" />
</span>
</div>
[%
CASE "sort_selector";
INCLUDE "opac/parts/filtersort.tt2"
+ id=adv_chunk.id
value=CGI.param('sort') class='results_header_sel';
%]
@@ -126,13 +128,13 @@
END;
ELSIF adv_chunk.adv_attr;
INCLUDE "opac/parts/coded_value_selector.tt2"
+ id=adv_chunk.id
attr=adv_chunk.adv_attr multiple="multiple"
- filter_label=l('Select [_1]', adv_chunk.adv_label)
size=adv_chunk.adv_size || search.default_adv_select_height || "4";
ELSIF adv_chunk.adv_filter;
INCLUDE "opac/parts/filter_group_selector.tt2"
+ id=adv_chunk.id
filter_group=adv_chunk.adv_filter multiple="multiple"
- filter_label=l('Select [_1]', adv_chunk.adv_label)
size=adv_chunk.adv_size || search.default_adv_select_height || "4";
END; %]
</div>
diff --git a/Open-ILS/src/templates/opac/parts/config.tt2 b/Open-ILS/src/templates/opac/parts/config.tt2
index 618d63a..96f8ce5 100644
--- a/Open-ILS/src/templates/opac/parts/config.tt2
+++ b/Open-ILS/src/templates/opac/parts/config.tt2
@@ -110,19 +110,22 @@ facet.default_display_count = 5;
# lib_selector will put the search library box (with limit to available)
# pub_year will put the publication year box
# sort_selector will put the sort results selector
+# id DOM id used for linking labels to form controls. They are pinned
+# here instead of auto-generated (from the attr type, for example)
+# for consistency.
search.adv_config = [
- {adv_label => l("Item Type"), adv_attr => ["mattype", "item_type"]},
- {adv_label => l("Item Form"), adv_attr => "item_form"},
- {adv_label => l("Language"), adv_attr => "item_lang"},
- {adv_label => l("Audience"), adv_attr => ["audience_group", "audience"], adv_break => 1},
- {adv_label => l("Video Format"), adv_attr => "vr_format"},
- {adv_label => l("Bib Level"), adv_attr => "bib_level"},
- {adv_label => l("Literary Form"), adv_attr => "lit_form"},
- {adv_label => l("Shelving Location"), adv_special => "copy_location", js_only => 1, adv_break => 1},
- {adv_label => l("Search Library"), adv_special => "lib_selector"},
- {adv_label => l("Publication Year"), adv_special => "pub_year"},
- {adv_label => l("Sort Results"), adv_special => "sort_selector"},
+ {adv_label => l("Item Type"), adv_attr => ["mattype", "item_type"], id => 'adv_selector_item_type'},
+ {adv_label => l("Item Form"), adv_attr => "item_form", id => 'adv_selector_item_form'},
+ {adv_label => l("Language"), adv_attr => "item_lang", id => 'adv_selector_item_lang'},
+ {adv_label => l("Audience"), adv_attr => ["audience_group", "audience"], id => 'adv_selector_audience', adv_break => 1},
+ {adv_label => l("Video Format"), adv_attr => "vr_format", id => 'adv_selector_video_format'},
+ {adv_label => l("Bib Level"), adv_attr => "bib_level", id => 'adv_selector_bib_level'},
+ {adv_label => l("Literary Form"), adv_attr => "lit_form", id => 'adv_selector_lit_form'},
+ {adv_label => l("Shelving Location"), adv_special => "copy_location", id => 'adv_copy_location_selector', js_only => 1, adv_break => 1},
+ {adv_label => l("Search Library"), adv_special => "lib_selector", id => 'adv_org_selector'},
+ {adv_label => l("Publication Year"), adv_special => "pub_year", id => 'adv_selector_pub_year'},
+ {adv_label => l("Sort Results"), adv_special => "sort_selector", id => 'adv_selector_sort_results'},
];
# Set the default height of the select boxes. Defaults to 4.
diff --git a/Open-ILS/src/templates/opac/parts/org_selector.tt2 b/Open-ILS/src/templates/opac/parts/org_selector.tt2
index 0246628..1b60855 100644
--- a/Open-ILS/src/templates/opac/parts/org_selector.tt2
+++ b/Open-ILS/src/templates/opac/parts/org_selector.tt2
@@ -28,7 +28,8 @@ BLOCK build_org_selector;
-%]
<select [% IF id %] id='[% id %]' [% END -%]
- [% IF arialabel %] aria-label='[% arialabel %]' [% END -%]
+ [% IF arialabel %] aria-label='[% arialabel %]'
+ [% ELSE %] title='[% l("Select Library") %]' [% END -%]
name='[% name %]'>
[%-
WHILE node_stack.size > 0;
commit ac298183bdbdcc5b77af15caeec20b14662213ac
Author: Bill Erickson <berick at esilibrary.com>
Date: Wed Apr 2 16:46:25 2014 -0400
LP#1301599 TPAC advanced search additional labels
Provides a number of labels, primarily for select widgets, in the TPAC
advanced search form for improved accessibility.
Signed-off-by: Bill Erickson <berick at esilibrary.com>
Signed-off-by: Ben Shum <bshum at biblio.org>
diff --git a/Open-ILS/src/templates/opac/parts/advanced/global_row.tt2 b/Open-ILS/src/templates/opac/parts/advanced/global_row.tt2
index 4d9ff4f..6302a29 100644
--- a/Open-ILS/src/templates/opac/parts/advanced/global_row.tt2
+++ b/Open-ILS/src/templates/opac/parts/advanced/global_row.tt2
@@ -27,7 +27,8 @@
<td align='left' width='100%'>
<!-- bool selector. hide for first row. safe to ignore first bool value in form submission -->
- <select name='bool' style='width: auto' [% IF loop.first %] class='invisible' [% END %]>
+ <select title="[% l('Boolean search operator') %]"
+ name='bool' style='width: auto' [% IF loop.first %] class='invisible' [% END %]>
<option value='and' [% b == 'and' ? 'selected="selected"' : '' %]>[% l('And') %]</option>
<option value='or' [% b == 'or' ? 'selected="selected"' : '' %]>[% l('Or') %]</option>
</select>
@@ -38,12 +39,14 @@
query_type=qtype %]
</span>
- <select name='contains' style='margin-right: 7px;'>
+ <select title="[% l('Search phrase match strictness') %]"
+ name='contains' style='margin-right: 7px;'>
[% FOR o IN contains_options; -%]
<option value="[% o.value %]" [% c == o.value ? ' selected="selected"' : '' %]>[% o.label %]</option>
[% END %]
</select>
- <input type='text' size='18' name='query' value="[% q | html %]" x-webkit-speech [% IF loop.index == 0 %] autofocus [% END %] />
+ <input title="[% l('Search term') %]"
+ type='text' size='18' name='query' value="[% q | html %]" x-webkit-speech [% IF loop.index == 0 %] autofocus [% END %] />
<a href="javascript:;" class="row-remover"
title="[% l('Remove row') %]" alt="[% l('Remove row') %]"
onclick='return killRowIfAtLeast(2, this);'>
diff --git a/Open-ILS/src/templates/opac/parts/advanced/search.tt2 b/Open-ILS/src/templates/opac/parts/advanced/search.tt2
index eb863a7..b6e5e3d 100644
--- a/Open-ILS/src/templates/opac/parts/advanced/search.tt2
+++ b/Open-ILS/src/templates/opac/parts/advanced/search.tt2
@@ -76,6 +76,7 @@
[%
CASE "pub_year"; %]
<select name='pubdate'
+ title="[% l('Publicatiion date search modifier') %]"
onchange='if(this.selectedIndex == 3)
unHideMe($("adv_global_pub_date_2_span"));
else
@@ -90,9 +91,11 @@
</select>
<br/>
<div id='adv_special_block'>
- <input name='date1' type='text' size='4' maxlength='4' value="[% CGI.param('date1') | html %]" />
+ <input title="[% l('First date') %]"
+ name='date1' type='text' size='4' maxlength='4' value="[% CGI.param('date1') | html %]" />
<span id='adv_global_pub_date_2_span' class='[% CGI.param("pubdate") == "between" ? "" : "hide_me" %]'>
- [% l("and") %] <input name='date2' type='text' size='4' maxlength='4' value="[% CGI.param('date2') | html %]" />
+ [% l("and") %] <input name='date2'
+ title="[% l('Second date') %]" type='text' size='4' maxlength='4' value="[% CGI.param('date2') | html %]" />
</span>
</div>
[%
@@ -123,10 +126,14 @@
END;
ELSIF adv_chunk.adv_attr;
INCLUDE "opac/parts/coded_value_selector.tt2"
- attr=adv_chunk.adv_attr multiple="multiple" size=adv_chunk.adv_size || search.default_adv_select_height || "4";
+ attr=adv_chunk.adv_attr multiple="multiple"
+ filter_label=l('Select [_1]', adv_chunk.adv_label)
+ size=adv_chunk.adv_size || search.default_adv_select_height || "4";
ELSIF adv_chunk.adv_filter;
INCLUDE "opac/parts/filter_group_selector.tt2"
- filter_group=adv_chunk.adv_filter multiple="multiple" size=adv_chunk.adv_size || search.default_adv_select_height || "4";
+ filter_group=adv_chunk.adv_filter multiple="multiple"
+ filter_label=l('Select [_1]', adv_chunk.adv_label)
+ size=adv_chunk.adv_size || search.default_adv_select_height || "4";
END; %]
</div>
</div>
diff --git a/Open-ILS/src/templates/opac/parts/coded_value_selector.tt2 b/Open-ILS/src/templates/opac/parts/coded_value_selector.tt2
index 7e6beb8..3c242f2 100644
--- a/Open-ILS/src/templates/opac/parts/coded_value_selector.tt2
+++ b/Open-ILS/src/templates/opac/parts/coded_value_selector.tt2
@@ -19,7 +19,7 @@
<select id='[% id %]' name='[% name %]'[%
multiple ? ' multiple="multiple"' : '';
size ? (' size="' _ size _ '"') : '';
-%] aria-label="[% l('Select item type:') %]">
+%] aria-label="[% filter_label || l('Select item type:') %]">
[% IF none_ok %]
<option value=''>[% none_label ? none_label : l('-- Any --') %]</option>
[% END;
diff --git a/Open-ILS/src/templates/opac/parts/filter_group_selector.tt2 b/Open-ILS/src/templates/opac/parts/filter_group_selector.tt2
index 239516d..8cab0ef 100644
--- a/Open-ILS/src/templates/opac/parts/filter_group_selector.tt2
+++ b/Open-ILS/src/templates/opac/parts/filter_group_selector.tt2
@@ -16,6 +16,7 @@
<select id='[% id %]' class='[% class %]' name='[% name %]'[%
multiple ? ' multiple="multiple"' : '';
+ title="[% filter_label || l('Search Filter') %]"
size ? (' size="' _ size _ '"') : ''; %]>
[% IF none_ok %]
<option value=''>[% none_label ? none_label : l('-- Any --') %]</option>
diff --git a/Open-ILS/src/templates/opac/parts/filtersort.tt2 b/Open-ILS/src/templates/opac/parts/filtersort.tt2
index 8d47979..1907058 100644
--- a/Open-ILS/src/templates/opac/parts/filtersort.tt2
+++ b/Open-ILS/src/templates/opac/parts/filtersort.tt2
@@ -1,4 +1,6 @@
-<select [% class ? ('class="' _ class _ '"') : '' %] id='[% id || "opac.result.sort" %]' name="[% name || 'sort' %]" [% IF submit_on_change %]onchange='this.form.submit()'[% END %]>
+<select title="[% l('Search sorting') %]"
+ [% class ? ('class="' _ class _ '"') : '' %] id='[% id || "opac.result.sort" %]'
+ name="[% name || 'sort' %]" [% IF submit_on_change %]onchange='this.form.submit()'[% END %]>
[% IF mode != 'bookbag' %]<option value=''>[% l("Sort by Relevance") %]</option>[% END %]
<optgroup label='[% l("Sort by Title") %]'>
<option value='titlesort'[% value == 'titlesort' ? ' selected="selected"' : '' %]>[% l("Title: A to Z") %]</option>
commit e0123927d816b4aeb269f5088939724a5ca8b64c
Author: Bill Erickson <berick at esilibrary.com>
Date: Wed Apr 2 16:43:49 2014 -0400
LP#1301599 TPAC result table accessibility improvements
* Give the main result table a screenreader-only header to describe the
table columns.
* Set the role=presentation in one of the sub-tables used only for
layout.
Signed-off-by: Bill Erickson <berick at esilibrary.com>
Signed-off-by: Ben Shum <bshum at biblio.org>
diff --git a/Open-ILS/src/templates/opac/parts/result/table.tt2 b/Open-ILS/src/templates/opac/parts/result/table.tt2
index 483d529..55e70a2 100644
--- a/Open-ILS/src/templates/opac/parts/result/table.tt2
+++ b/Open-ILS/src/templates/opac/parts/result/table.tt2
@@ -30,6 +30,13 @@
<div id="result_block" class="result_block_visible">
<table id="result_table_table" title="[% l('Search Results') %]"
class="table_no_border_space table_no_cell_pad">
+ <thead class="sr-only">
+ <tr>
+ <th>[% l('Search result number') %]</th>
+ <th>[% l('Book jacket cover art') %]</th>
+ <th>[% l('Item details and Actions') %]</th>
+ </tr>
+ </thead>
<tbody id="result_table">
[% FOR rec IN ctx.records;
attrs = {marc_xml => rec.marc_xml};
@@ -146,6 +153,7 @@ END;
-%]
</div>
<table
+ role="presentation"
title="[% l('Record Holdings Summary') %]"
class="table_no_border_space table_no_cell_pad table_no_border results_info_table">
[% IF args.holdings.size > 0 %]
-----------------------------------------------------------------------
Summary of changes:
Open-ILS/src/templates/opac/css/style.css.tt2 | 7 +++++
Open-ILS/src/templates/opac/myopac/holds.tt2 | 1 -
.../templates/opac/parts/advanced/global_row.tt2 | 9 ++++--
.../src/templates/opac/parts/advanced/search.tt2 | 27 +++++++++++++------
.../templates/opac/parts/coded_value_selector.tt2 | 2 +-
Open-ILS/src/templates/opac/parts/config.tt2 | 25 ++++++++++--------
.../templates/opac/parts/filter_group_selector.tt2 | 1 +
Open-ILS/src/templates/opac/parts/filtersort.tt2 | 4 ++-
Open-ILS/src/templates/opac/parts/myopac/base.tt2 | 1 -
.../src/templates/opac/parts/myopac/prefs_base.tt2 | 3 +-
Open-ILS/src/templates/opac/parts/org_selector.tt2 | 2 +-
.../src/templates/opac/parts/qtype_selector.tt2 | 2 +-
.../src/templates/opac/parts/result/facets.tt2 | 2 +-
Open-ILS/src/templates/opac/parts/result/table.tt2 | 8 ++++++
Open-ILS/src/templates/opac/results.tt2 | 5 ++-
15 files changed, 65 insertions(+), 34 deletions(-)
hooks/post-receive
--
Evergreen ILS
More information about the open-ils-commits
mailing list