[open-ils-commits] ***SPAM*** [GIT] Evergreen ILS branch rel_2_6 updated. 9bf650bca7baebe760bf79958808c918edddb13b

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_2_6 has been updated
       via  9bf650bca7baebe760bf79958808c918edddb13b (commit)
      from  f1c07d5f83ae1bb4955040510673625edd4a2f89 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 9bf650bca7baebe760bf79958808c918edddb13b
Author: Remington Steed <rjs7 at calvin.edu>
Date:   Fri Mar 7 13:56:25 2014 -0500

    Remove buggy, unused function get_leaders_from_usergroup
    
    Recent editing and testing of get_leaders_from_usergroup() uncovered an
    unrelated bug which renders the function useless (it returns all group
    members, not just the leader). It wasn't previously caught because
    Evergreen has no apparent references to this function. This commit
    removes the unused function.
    
    Signed-off-by: Remington Steed <rjs7 at calvin.edu>
    Signed-off-by: Dan Wells <dbw2 at calvin.edu>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Actor/UserGroups.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Actor/UserGroups.pm
index 0a94956..4d6913f 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Actor/UserGroups.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Actor/UserGroups.pm
@@ -64,33 +64,6 @@ sub get_users_from_usergroup {
 
 
 __PACKAGE__->register_method(
-    method => 'get_leaders_from_usergroup',
-    api_name    => 'open-ils.actor.usergroup.leaders.retrieve',
-    signature   => q/
-        Returns a list of ids for users that are leaders of the given usergroup
-    /
-);
-
-sub get_leaders_from_usergroup {
-    my( $self, $conn, $auth, $usergroup ) = @_;
-    my $e = new_editor(authtoken=>$auth);
-    return $e->event unless $e->checkauth;
-    return $e->event unless $e->allowed('VIEW_USER'); # XXX reley on editor perm
-    my $users = $e->search_actor_user(
-        {usrgroup => $usergroup, deleted => 'f'})
-        or return $e->event;
-
-    my @res;
-    for my $u (@$users) {
-        push( @res, $u->id ) if $u->master_account;
-    }
-
-    return \@res;
-}
-
-
-
-__PACKAGE__->register_method(
     method => 'get_address_members',
     api_name    => 'open-ils.actor.address.members',
     signature   => q/

-----------------------------------------------------------------------

Summary of changes:
 .../lib/OpenILS/Application/Actor/UserGroups.pm    |   27 --------------------
 1 files changed, 0 insertions(+), 27 deletions(-)


hooks/post-receive
-- 
Evergreen ILS