[open-ils-commits] ***SPAM*** [GIT] Evergreen ILS branch rel_2_7 updated. d52c7a0c85964329b4b9f8104d67ce7165e4a844

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_2_7 has been updated
       via  d52c7a0c85964329b4b9f8104d67ce7165e4a844 (commit)
      from  58b0239f3a7851a7cbaf1b29386bd2895eba081b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit d52c7a0c85964329b4b9f8104d67ce7165e4a844
Author: Jason Stephenson <jstephenson at mvlc.org>
Date:   Wed Oct 30 11:05:45 2013 -0400

    LP#1246371: Allow BibCommon::title_is_empty to accept a bre id or bre object.
    
    I was trying to delete copies with the record fleshed in the call number
    object and got the following error:
    
    Can't use an undefined value as an ARRAY reference at
    /usr/local/share/perl/5.14.2/OpenILS/Application/Cat/BibCommon.pm line 399
    
    Having title_is_empty check for a bre object and use its id solved this
    problem for me.
    
    Signed-off-by: Jason Stephenson <jstephenson at mvlc.org>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Cat/BibCommon.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Cat/BibCommon.pm
index ff2c3ab..0e9da73 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Cat/BibCommon.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Cat/BibCommon.pm
@@ -391,6 +391,10 @@ sub delete_rec {
 sub title_is_empty {
     my($class, $editor, $rid, $vol_id) = @_;
 
+    # check if $rid is an object, because may be passing the volume
+    # with a fleshed record in one of our callers.
+    $rid = $rid->id() if (ref($rid));
+
     return 0 if $rid == OILS_PRECAT_RECORD;
 
     my $cnlist = $editor->search_asset_call_number(

-----------------------------------------------------------------------

Summary of changes:
 .../lib/OpenILS/Application/Cat/BibCommon.pm       |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)


hooks/post-receive
-- 
Evergreen ILS