[open-ils-commits] ***SPAM*** [GIT] Evergreen ILS branch master updated. 8b21c1c0d79bb437298e38dfef838591f4eaeed5

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  8b21c1c0d79bb437298e38dfef838591f4eaeed5 (commit)
       via  7ecc442a45668db8a8b1e7aab667c1dc6657b934 (commit)
      from  609db84f0499cf7083b09d1786ace1a60f71986e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 8b21c1c0d79bb437298e38dfef838591f4eaeed5
Author: Jason Stephenson <jason at sigio.com>
Date:   Thu Jan 29 08:02:03 2015 -0500

    LP#1415898 Fix Potential Cstore Starvation in the OPAC
    
    When a user views their current circulations and/or renews them via
    the OPAC, a connection is made to a cstore drone so that the user's
    circulations can be retrieved from the database, bypassing the cache.
    This connection is not closed, and thus a cstore drone is left unable
    to respond to new requests for several seconds.  On a busy server,
    this has actually caused the number of cstore drones to hit the limit
    configured in opensrf.xml.  If that situation continues for too long,
    it leads to the load on the server spiking to the point where services
    must be restarted.
    
    This commit changes from xact_rollback to rollback so that the connection
    will be closed.
    
    Signed-off-by: Jason Stephenson <jason at sigio.com>
    Signed-off-by: Bill Erickson <berickxx at gmail.com>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Account.pm b/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Account.pm
index c2e6450..4a2b5dc 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Account.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Account.pm
@@ -1247,7 +1247,7 @@ sub fetch_user_circs {
                 undef  # pre-cat copy, use the dummy title/author instead
         });
     }
-    $e->xact_rollback;
+    $e->rollback;
 
     # make sure the final list is in the correct order
     my @sorted_circs;

commit 7ecc442a45668db8a8b1e7aab667c1dc6657b934
Author: Jason Stephenson <jason at sigio.com>
Date:   Thu Jan 29 07:59:07 2015 -0500

    LP#1415898 Fix Potential Cstore Starvation in KPAC
    
    The getit_results function in EGKPacLoader.pm does xact_begin, which
    opens a connected session to a cstore drone.  It later does xact_rollback,
    which does not disconnect the session.  This leaves a drone hanging for
    several seconds unable to responde to new requests.  This commit switches
    to a rollback call that does disconnect the session.
    
    Signed-off-by: Jason Stephenson <jason at sigio.com>
    Signed-off-by: Bill Erickson <berickxx at gmail.com>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGKPacLoader.pm b/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGKPacLoader.pm
index 0598947..32e394b 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGKPacLoader.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGKPacLoader.pm
@@ -222,7 +222,7 @@ sub load_getit_results {
     } else { 
         $e->xact_begin;
         $ctx->{hold} = $e->retrieve_action_hold_request($hold_id);
-        $e->xact_rollback;
+        $e->rollback;
     }
 
     return Apache2::Const::OK;

-----------------------------------------------------------------------

Summary of changes:
 .../lib/OpenILS/WWW/EGCatLoader/Account.pm         |    2 +-
 .../src/perlmods/lib/OpenILS/WWW/EGKPacLoader.pm   |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
Evergreen ILS