[open-ils-commits] [GIT] Evergreen ILS branch master updated. 6f332bac34eee8d9eae3c8a56af6bd9675d6cff6

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  6f332bac34eee8d9eae3c8a56af6bd9675d6cff6 (commit)
       via  8a103910aab22302528dcdea1b3b42e315f6558a (commit)
      from  ea55537955c4f632615f9104d53ed76f4a6a0263 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 6f332bac34eee8d9eae3c8a56af6bd9675d6cff6
Author: Ben Shum <bshum at biblio.org>
Date:   Tue Jul 28 16:40:55 2015 -0400

    LP#1466201: Release note for disabling Google Analytics in staff interface
    
    Signed-off-by: Ben Shum <bshum at biblio.org>

diff --git a/docs/RELEASE_NOTES_NEXT/Client/disable-google-analytics.txt b/docs/RELEASE_NOTES_NEXT/Client/disable-google-analytics.txt
new file mode 100644
index 0000000..ba06600
--- /dev/null
+++ b/docs/RELEASE_NOTES_NEXT/Client/disable-google-analytics.txt
@@ -0,0 +1,5 @@
+Disable Google Analytics in Staff Client
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+In the staff client interface, Google Analytics for the web catalog is
+now disabled by default. This was a preventive measure to reduce the
+potential risks for leaking patron information.

commit 8a103910aab22302528dcdea1b3b42e315f6558a
Author: Kathy Lussier <klussier at masslnc.org>
Date:   Thu Jul 9 23:23:08 2015 -0400

    lp1466201 Disable Google Analytics in the staff client
    
    As Galen Charlton noted in bug 1452883, "I suggest disabling Google Analytics
    outright in the staff client; there's far too much potential for leaking patron
    information." This branch aims to do so.
    
    Test plan: Enable Google Analytics in config.tt2. Access the catalog in the
    staff client. Click Debug to view the source code. Pre-patch, you'll see
    the Google Analytics javascript within the head element. Post-patch, that
    javascript will be gone. Viewing the source of a catalog page in a browser
    should continue to show the Google Analytics javascript within the head element.
    
    Signed-off-by: Kathy Lussier <klussier at masslnc.org>
    Signed-off-by: Ben Shum <bshum at biblio.org>

diff --git a/Open-ILS/src/templates/opac/parts/base.tt2 b/Open-ILS/src/templates/opac/parts/base.tt2
index 8c24507..1a3a979 100644
--- a/Open-ILS/src/templates/opac/parts/base.tt2
+++ b/Open-ILS/src/templates/opac/parts/base.tt2
@@ -31,7 +31,9 @@
         </style>
         [% END %]
 
-        [% INCLUDE 'opac/parts/goog_analytics.tt2' %]
+        [% IF !ctx.is_staff %]
+            [% INCLUDE 'opac/parts/goog_analytics.tt2' %]
+        [% END %]
         [% PROCESS 'opac/parts/stripe.tt2' %]
     </head>
     <body[% IF want_dojo; ' class="tundra"'; END %]>

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/src/templates/opac/parts/base.tt2         |    4 +++-
 .../Client/disable-google-analytics.txt            |    5 +++++
 2 files changed, 8 insertions(+), 1 deletions(-)
 create mode 100644 docs/RELEASE_NOTES_NEXT/Client/disable-google-analytics.txt


hooks/post-receive
-- 
Evergreen ILS