[open-ils-commits] [GIT] Evergreen ILS branch rel_2_9 updated. 4cf6cc76bd063f88027fb18f7687c613a4d4813f

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_2_9 has been updated
       via  4cf6cc76bd063f88027fb18f7687c613a4d4813f (commit)
      from  4eab98f15fb6f70c06b4f360d9dfa08cc19fb7f4 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 4cf6cc76bd063f88027fb18f7687c613a4d4813f
Author: Jason Stephenson <jstephenson at mvlc.org>
Date:   Thu Sep 17 15:12:40 2015 -0400

    LP 1496977: Duplicate Code in OpenILS::Application::Cat::AssetCommon
    
    It looks like two lines of code got duplicated in commit e2f6cca0 in
    AssetCommon.  This duplication can lead to data loss for the function
    update_fleshed_copies.  It also lead to the following warning when
    you use OpenILS::Application::Cat::AssetCommon in a script:
    
    "my" variable $sc_entries masks earlier declaration in same scope at
    /usr/local/share/perl/5.18.2/OpenILS/Application/Cat/AssetCommon.pm
    line 371.
    
    After this patch, the warning disappears.
    
    Signed-off-by: Jason Stephenson <jstephenson at mvlc.org>
    Signed-off-by: Ben Shum <bshum at biblio.org>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Cat/AssetCommon.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Cat/AssetCommon.pm
index fe0913c..626595b 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Cat/AssetCommon.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Cat/AssetCommon.pm
@@ -368,9 +368,6 @@ sub update_fleshed_copies {
         my $sc_entries = $copy->stat_cat_entries;
         $copy->clear_stat_cat_entries;
 
-        my $sc_entries = $copy->stat_cat_entries;
-        $copy->clear_stat_cat_entries;
-
         my $notes = $copy->notes;
         $copy->clear_notes;
 

-----------------------------------------------------------------------

Summary of changes:
 .../lib/OpenILS/Application/Cat/AssetCommon.pm     |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)


hooks/post-receive
-- 
Evergreen ILS