[open-ils-commits] [GIT] Evergreen ILS branch master updated. abefaa0dffe415bca9669de7a884ce22d6a9c2a3

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  abefaa0dffe415bca9669de7a884ce22d6a9c2a3 (commit)
      from  3a3d27fe5b0d94d088373d54a766fa652fe298e8 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit abefaa0dffe415bca9669de7a884ce22d6a9c2a3
Author: Kathy Lussier <klussier at masslnc.org>
Date:   Tue Jul 19 14:02:12 2016 -0400

    LP#1604515: Remove Advanced Hold Options link when part holds are expected
    
    This branch removes the Advanced Hold Options link from the Place Hold
    screen in cases where all copies on the bib record contain parts. If a user
    attempts to place a metarecord hold and all other copies in the group also
    contain parts, the hold will fail. By removing the link, we are removing one
    potential point of failure for the user.
    
    Signed-off-by: Kathy Lussier <klussier at masslnc.org>
    Signed-off-by: Mike Rylander <mrylander at gmail.com>

diff --git a/Open-ILS/src/templates/opac/parts/place_hold.tt2 b/Open-ILS/src/templates/opac/parts/place_hold.tt2
index 55f1184..c4f197d 100644
--- a/Open-ILS/src/templates/opac/parts/place_hold.tt2
+++ b/Open-ILS/src/templates/opac/parts/place_hold.tt2
@@ -125,7 +125,7 @@
                         [% END %]
                     [% END %]
                     [% IF NOT metarecords.disabled %]
-                        [% IF CGI.param('hold_type') == 'T' AND hdata.record.metarecord %]
+                        [% IF CGI.param('hold_type') == 'T' AND hdata.record.metarecord AND !hdata.part_required %]
                         <!-- Grab the bre_id so that we can restore it if user accidentally clicks advanced options -->
                            [% bre_id = hdata.target.id %]
                             <a  id='advanced_hold_link'
diff --git a/docs/RELEASE_NOTES_NEXT/OPAC/remove_advanced_hold_options_for_parts.adoc b/docs/RELEASE_NOTES_NEXT/OPAC/remove_advanced_hold_options_for_parts.adoc
new file mode 100644
index 0000000..3f2f642
--- /dev/null
+++ b/docs/RELEASE_NOTES_NEXT/OPAC/remove_advanced_hold_options_for_parts.adoc
@@ -0,0 +1,9 @@
+Removal of Advanced Hold Options link when part holds are expected
+^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
+If a user attempts to place a metarecord hold when all eligible copies
+contain parts, the hold will fail. To help prevent the user from reaching
+a dead end while placing holds, the _Advanced Hold Options_ link is removed
+from the Place Hold page in cases where all copies on the record contain
+parts. The _Advanced Hold Options_ link will remain for records that have
+a mix of parted and non-parted copies.
+

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/src/templates/opac/parts/place_hold.tt2   |    2 +-
 .../remove_advanced_hold_options_for_parts.adoc    |    9 +++++++++
 2 files changed, 10 insertions(+), 1 deletions(-)
 create mode 100644 docs/RELEASE_NOTES_NEXT/OPAC/remove_advanced_hold_options_for_parts.adoc


hooks/post-receive
-- 
Evergreen ILS