[open-ils-commits] [GIT] Evergreen ILS branch master updated. 233e61f3c194974b1316886e49d94b65c90a46f1

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  233e61f3c194974b1316886e49d94b65c90a46f1 (commit)
       via  8bfa94f1aad7cc9e0b6d15e1c11365bc751a4fd0 (commit)
      from  18c0241d4f8cc590f89070f767b786d58c312951 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 233e61f3c194974b1316886e49d94b65c90a46f1
Author: Dan Scott <dscott at laurentian.ca>
Date:   Mon Dec 12 16:13:00 2016 -0500

    LP#1594937 Fix off-by-one display of closed dates
    
    The switch to toISOString() to format dates introduced an off-by-one error in
    the closed dates display, showing one extra day of closure due to the timezone
    being ignored in toISOString().
    
    toLocaleDateString() is the future of locale-sensitive date formats. In XUL,
    because it is an old version of Firefox, it lacks locale sensitivity, but for
    the purposes of the web staff client it's a good base to build on as even
    Internet Explorer supports the locale and options arguments as of IE 11.
    
    And for the immediate purposes of showing the right dates in the closed dates
    editor, it works.
    
    Signed-off-by: Dan Scott <dscott at laurentian.ca>
    Signed-off-by: Chris Sharp <csharp at georgialibraries.org>

diff --git a/Open-ILS/xul/staff_client/server/admin/closed_dates.js b/Open-ILS/xul/staff_client/server/admin/closed_dates.js
index 732b17c..ced1577 100644
--- a/Open-ILS/xul/staff_client/server/admin/closed_dates.js
+++ b/Open-ILS/xul/staff_client/server/admin/closed_dates.js
@@ -174,7 +174,7 @@ function cdDateToHours(date) {
 
 function cdDateToDate(date) {
     var date_obj = new Date(Date.parse(date));
-    return date_obj.toISOString().replace(/T.*/,''); // == %F
+    return date_obj.toLocaleDateString();
 }
 
 

commit 8bfa94f1aad7cc9e0b6d15e1c11365bc751a4fd0
Author: Dan Scott <dscott at laurentian.ca>
Date:   Mon Dec 12 15:39:08 2016 -0500

    LP#1432753 Restore "All day" verbiage to Closed Dates editor
    
    Commit ede7e78925 replaced the JSAN calls to util.date.formatted_date() with
    inline date/time handling, in the process returning times with granularity to
    the minute instead of to the second. This resulted in the test for "all day"
    closings always failing.
    
    Signed-off-by: Dan Scott <dscott at laurentian.ca>
    Signed-off-by: Chris Sharp <csharp at georgialibraries.org>

diff --git a/Open-ILS/xul/staff_client/server/admin/closed_dates.js b/Open-ILS/xul/staff_client/server/admin/closed_dates.js
index 50d74c2..732b17c 100644
--- a/Open-ILS/xul/staff_client/server/admin/closed_dates.js
+++ b/Open-ILS/xul/staff_client/server/admin/closed_dates.js
@@ -191,7 +191,7 @@ function cdBuildRow( date ) {
     var row;
     var flesh = false;
 
-    if( sh == '00:00:00' && eh == '23:59:59' ) {
+    if( sh == '00:00' && eh == '23:59' ) {
 
         if( sd == ed ) {
             row = cdAllDayTemplate.cloneNode(true);

-----------------------------------------------------------------------

Summary of changes:
 .../xul/staff_client/server/admin/closed_dates.js  |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
Evergreen ILS