[open-ils-commits] [GIT] Evergreen ILS branch master updated. 3f778195c62baa6d438143d4d167adda180b771e

Evergreen Git git at git.evergreen-ils.org
Fri Feb 12 17:00:41 EST 2016


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  3f778195c62baa6d438143d4d167adda180b771e (commit)
      from  ac60ad87020a56667e56efc69874e78fbd028840 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 3f778195c62baa6d438143d4d167adda180b771e
Author: Josh Stompro <stomproj at larl.org>
Date:   Sun Nov 8 20:51:04 2015 -0600

    LP#1240657 - Creating and Deleting Closed Dates permissions wrong.
    
    The code referenced two permissions that didn't exist
    CREATE_CLOSEING and DELETE_CLOSEING.  Should be CREATE_ORG_UNIT_CLOSING,
    and DELETE_ORG_UNIT_CLOSING.
    
    [RM note: the affected methods don't appear to be in use, however]
    
    Signed-off-by: Josh Stompro <stomproj at larl.org>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Actor.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Actor.pm
index 050dfbb..d752589 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Actor.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Actor.pm
@@ -2760,7 +2760,7 @@ sub create_closed_date {
     my( $user, $evt ) = $U->checkses($authtoken);
     return $evt if $evt;
 
-    $evt = $U->check_perms($user->id, $cd->org_unit, 'CREATE_CLOSEING');
+    $evt = $U->check_perms($user->id, $cd->org_unit, 'CREATE_ORG_UNIT_CLOSING');
     return $evt if $evt;
 
     $logger->activity("user ".$user->id." creating library closing for ".$cd->org_unit);
@@ -2791,7 +2791,7 @@ sub delete_closed_date {
     ($cd_obj, $evt) = fetch_closed_date($cd);
     return $evt if $evt;
 
-    $evt = $U->check_perms($user->id, $cd->org_unit, 'DELETE_CLOSEING');
+    $evt = $U->check_perms($user->id, $cd->org_unit, 'DELETE_ORG_UNIT_CLOSING');
     return $evt if $evt;
 
     $logger->activity("user ".$user->id." deleting library closing for ".$cd->org_unit);

-----------------------------------------------------------------------

Summary of changes:
 .../src/perlmods/lib/OpenILS/Application/Actor.pm  |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
Evergreen ILS


More information about the open-ils-commits mailing list