[open-ils-commits] [GIT] Evergreen ILS branch master updated. 49590f0f0600be28ab28c6f55487c9992993a398

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  49590f0f0600be28ab28c6f55487c9992993a398 (commit)
      from  4b40e68a8757c3c80a4c0c8ba9d6de60bc1f1af5 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 49590f0f0600be28ab28c6f55487c9992993a398
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Fri Feb 12 17:10:25 2016 -0500

    LP#1545178: remove two unused methods
    
    This patch removes two methods that were both broken
    and not in use:
    
      * open-ils.actor.org_unit.closed_date.create
      * open-ils.actor.org_unit.closed_date.delete
    
    To test:
    
    [1] This patch has no user-visible impact whatsoever, but
        to check for regressions, verify the proper functioning
        of the closed dates editor.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    Signed-off-by: Ben Shum <ben at evergreener.net>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Actor.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Actor.pm
index d752589..e5b4316 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Actor.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Actor.pm
@@ -2746,64 +2746,6 @@ sub fetch_patron_messages {
 
 
 __PACKAGE__->register_method(
-    method    => 'create_closed_date',
-    api_name  => 'open-ils.actor.org_unit.closed_date.create',
-    signature => q/
-        Creates a new closing entry for the given org_unit
-        @param authtoken The login session key
-        @param note The closed_date object
-    /
-);
-sub create_closed_date {
-    my( $self, $conn, $authtoken, $cd ) = @_;
-
-    my( $user, $evt ) = $U->checkses($authtoken);
-    return $evt if $evt;
-
-    $evt = $U->check_perms($user->id, $cd->org_unit, 'CREATE_ORG_UNIT_CLOSING');
-    return $evt if $evt;
-
-    $logger->activity("user ".$user->id." creating library closing for ".$cd->org_unit);
-
-    my $id = $U->storagereq(
-        'open-ils.storage.direct.actor.org_unit.closed_date.create', $cd );
-    return $U->DB_UPDATE_FAILED($cd) unless $id;
-    return $id;
-}
-
-
-__PACKAGE__->register_method(
-    method    => 'delete_closed_date',
-    api_name  => 'open-ils.actor.org_unit.closed_date.delete',
-    signature => q/
-        Deletes a closing entry for the given org_unit
-        @param authtoken The login session key
-        @param noteid The close_date id
-    /
-);
-sub delete_closed_date {
-    my( $self, $conn, $authtoken, $cd ) = @_;
-
-    my( $user, $evt ) = $U->checkses($authtoken);
-    return $evt if $evt;
-
-    my $cd_obj;
-    ($cd_obj, $evt) = fetch_closed_date($cd);
-    return $evt if $evt;
-
-    $evt = $U->check_perms($user->id, $cd->org_unit, 'DELETE_ORG_UNIT_CLOSING');
-    return $evt if $evt;
-
-    $logger->activity("user ".$user->id." deleting library closing for ".$cd->org_unit);
-
-    my $stat = $U->storagereq(
-        'open-ils.storage.direct.actor.org_unit.closed_date.delete', $cd );
-    return $U->DB_UPDATE_FAILED($cd) unless $stat;
-    return $stat;
-}
-
-
-__PACKAGE__->register_method(
     method    => 'usrname_exists',
     api_name  => 'open-ils.actor.username.exists',
     signature => {
diff --git a/docs/RELEASE_NOTES_NEXT/Development/remove_unused_methods.adoc b/docs/RELEASE_NOTES_NEXT/Development/remove_unused_methods.adoc
new file mode 100644
index 0000000..945b93d
--- /dev/null
+++ b/docs/RELEASE_NOTES_NEXT/Development/remove_unused_methods.adoc
@@ -0,0 +1,8 @@
+Removal of unused methods
+^^^^^^^^^^^^^^^^^^^^^^^^^
+The following public methods, which were both broken and not in use,
+are removed:
+
+ * `open-ils.actor.org_unit.closed_date.create`
+ * `open-ils.actor.org_unit.closed_date.delete`
+

-----------------------------------------------------------------------

Summary of changes:
 .../src/perlmods/lib/OpenILS/Application/Actor.pm  |   58 --------------------
 .../Development/remove_unused_methods.adoc         |    8 +++
 2 files changed, 8 insertions(+), 58 deletions(-)
 create mode 100644 docs/RELEASE_NOTES_NEXT/Development/remove_unused_methods.adoc


hooks/post-receive
-- 
Evergreen ILS