[open-ils-commits] [GIT] Evergreen ILS branch master updated. 59503ede86bb06c97319f12e96bc30604264307d

Evergreen Git git at git.evergreen-ils.org
Wed Nov 2 11:38:44 EDT 2016


This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  59503ede86bb06c97319f12e96bc30604264307d (commit)
      from  c6f486fd1bce40f722b2072cef69e59ac6df678b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 59503ede86bb06c97319f12e96bc30604264307d
Author: Kathy Lussier <klussier at masslnc.org>
Date:   Mon May 23 20:09:34 2016 -0400

    LP#1584807: Clicking column header should not unsort list
    
    Clicking column headers in My Account cycled through ascending order,
    descending order, and then unsorted. But unsorting a list after clicking a
    header is unintutive to the user. Instead, it should toggle between ascending /
    descending order.
    
    Test plan
    * Using the concerto dataset, log in as user 99999395984 / maes1234
    * Go to the Items Out area of my account and click the title column header to
    sort the list.
    * The list will first sort alphabetically in ascending order, on a second click
    will sort alphabetically in descending order, and, on a third click, will
    return to the default sort order.
    * After loading the patch, clicking the column header should only result in
    sorting in ascending and descending order.
    
    Signed-off-by: Kathy Lussier <klussier at masslnc.org>
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    Signed-off-by: Jason Stephenson <jason at sigio.com>

diff --git a/Open-ILS/src/templates/opac/parts/myopac/column_sort_support.tt2 b/Open-ILS/src/templates/opac/parts/myopac/column_sort_support.tt2
index eb2bc49..6d5ba47 100644
--- a/Open-ILS/src/templates/opac/parts/myopac/column_sort_support.tt2
+++ b/Open-ILS/src/templates/opac/parts/myopac/column_sort_support.tt2
@@ -7,8 +7,6 @@
                 CASE "asc";
                    mkurl('',{sort=>field, sort_type=>'desc'},1);
                 CASE "desc";
-                   mkurl('',{},1);
-                CASE;
                    mkurl('',{sort=>field, sort_type=>'asc'}, 1);
                 END;
 	ELSE;

-----------------------------------------------------------------------

Summary of changes:
 .../opac/parts/myopac/column_sort_support.tt2      |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
Evergreen ILS


More information about the open-ils-commits mailing list