[open-ils-commits] [GIT] Evergreen ILS branch rel_2_11 updated. 5924d3a93aaf2ea85d996fb37c9638ec42bc93f8

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_2_11 has been updated
       via  5924d3a93aaf2ea85d996fb37c9638ec42bc93f8 (commit)
      from  975057a5ec197a32e3c998d3badb2528fed789b1 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 5924d3a93aaf2ea85d996fb37c9638ec42bc93f8
Author: Dan Scott <dscott at laurentian.ca>
Date:   Fri Sep 16 13:49:01 2016 -0400

    LP#1624491 Avoid uninit var prox_cache during holds processing
    
    open-ils.circ was logging a prox_cache hash value before it is
    guaranteed to have been initialized. Instead, log messages _after_ they
    have been initialized.
    
    Signed-off-by: Dan Scott <dscott at laurentian.ca>
    Signed-off-by: Mike Rylander <mrylander at gmail.com>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm
index 021d3bb..5d08462 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Circ/Holds.pm
@@ -2617,12 +2617,11 @@ sub _check_title_hold_is_possible {
     my $home_org = $patron->home_ou;
     my $req_org = $request_lib->id;
 
-    $logger->info("prox cache $home_org " . $prox_cache{$home_org});
-
     $prox_cache{$home_org} =
         $e->search_actor_org_unit_proximity({from_org => $home_org})
         unless $prox_cache{$home_org};
     my $home_prox = $prox_cache{$home_org};
+    $logger->info("prox cache $home_org " . $prox_cache{$home_org});
 
     my %buckets;
     my %hash = map { ($_->to_org => $_->prox) } @$home_prox;
@@ -2750,12 +2749,11 @@ sub _check_issuance_hold_is_possible {
     my $home_org = $patron->home_ou;
     my $req_org = $request_lib->id;
 
-    $logger->info("prox cache $home_org " . $prox_cache{$home_org});
-
     $prox_cache{$home_org} =
         $e->search_actor_org_unit_proximity({from_org => $home_org})
         unless $prox_cache{$home_org};
     my $home_prox = $prox_cache{$home_org};
+    $logger->info("prox cache $home_org " . $prox_cache{$home_org});
 
     my %buckets;
     my %hash = map { ($_->to_org => $_->prox) } @$home_prox;
@@ -2891,12 +2889,11 @@ sub _check_monopart_hold_is_possible {
     my $home_org = $patron->home_ou;
     my $req_org = $request_lib->id;
 
-    $logger->info("prox cache $home_org " . $prox_cache{$home_org});
-
     $prox_cache{$home_org} =
         $e->search_actor_org_unit_proximity({from_org => $home_org})
         unless $prox_cache{$home_org};
     my $home_prox = $prox_cache{$home_org};
+    $logger->info("prox cache $home_org " . $prox_cache{$home_org});
 
     my %buckets;
     my %hash = map { ($_->to_org => $_->prox) } @$home_prox;

-----------------------------------------------------------------------

Summary of changes:
 .../perlmods/lib/OpenILS/Application/Circ/Holds.pm |    9 +++------
 1 files changed, 3 insertions(+), 6 deletions(-)


hooks/post-receive
-- 
Evergreen ILS