[open-ils-commits] [GIT] Evergreen ILS branch master updated. a073b5a441576e3348391669a6e6ea94a304a5ce

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  a073b5a441576e3348391669a6e6ea94a304a5ce (commit)
      from  97dda314bee85b2d5cac153fd11523473c0f5115 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit a073b5a441576e3348391669a6e6ea94a304a5ce
Author: Mike Rylander <mrylander at gmail.com>
Date:   Tue Aug 1 12:34:11 2017 -0400

    LP#1707549: Remove Perl 5.24+ syntax restriction
    
    Quoth the Perl docs: "An experimental feature added in Perl 5.14 allowed each,
    keys, push, pop, shift, splice, unshift, and values to be called with a scalar
    argument. This experiment is considered unsuccessful, and has been removed.
    The postderef feature may meet your needs better."
    
    The specific instance here was probably just a typo or thinko the did the
    right thing on Perls "of a certain age" ... so, we fix that here, now.
    
    To test:
    
    [1] Upon applying the patch, verify that Perl 5.24+ will successfully
        compile metabib.pm, that the open-ils.storage service will
        start up, and that catalog searches continue to work.
    
    Signed-off-by: Mike Rylander <mrylander at gmail.com>
    Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/metabib.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/metabib.pm
index 92ba04c..d8a65c1 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/metabib.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Storage/Publisher/metabib.pm
@@ -3186,7 +3186,7 @@ sub query_parser_fts_wrapper {
     $top_org ||= actor::org_unit->search( { parent_ou => undef } )->next;
 
     my $base_query = $args{query} || '';
-    if (scalar(keys($args{searches}))) {
+    if (scalar(keys(%{$args{searches}}))) {
         $log->debug("Constructing QueryParser query from staged search hash ...", DEBUG);
         for my $sclass ( keys %{$args{searches}} ) {
             $log->debug(" --> staged search key: $sclass --> term: $args{searches}{$sclass}{term}", DEBUG);

-----------------------------------------------------------------------

Summary of changes:
 .../Application/Storage/Publisher/metabib.pm       |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
Evergreen ILS