[open-ils-commits] [GIT] Evergreen ILS branch rel_2_12 updated. 3eb759100eb4bd5f0342f31fba3ad365383b5310

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_2_12 has been updated
       via  3eb759100eb4bd5f0342f31fba3ad365383b5310 (commit)
      from  b8ebe0a1702bcc7e07ece652caa70d694f98436a (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 3eb759100eb4bd5f0342f31fba3ad365383b5310
Author: Cesar Velez <cesar.velez at equinoxinitiative.org>
Date:   Tue May 23 09:58:39 2017 -0400

    LP#1669534 - OPAC hold request should not default to first SMS carrier
    
    Added empty <option> tag to address this and related form validation issues.
    
    To test
    -------
    [0] Ensure that SMS messaging is enabled.
    [1] Apply the patch and go to the place hold form in the public
        catalog. Verify that no mobile carrier is selected.
    [2] Set the default SMS carrier and number for the user account
        and go back to the place hold form. Verify that the user's
        default carrier and number appear in the form.
    
    Signed-off by: Cesar Velez <cesar.velez at equinoxinitiative.org>
    Signed-off-by: Chris Sharp <csharp at georgialibraries.org>
    Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>
    
    Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>

diff --git a/Open-ILS/src/templates/opac/parts/sms_carrier_selector.tt2 b/Open-ILS/src/templates/opac/parts/sms_carrier_selector.tt2
index 919ba07..1f66d15 100644
--- a/Open-ILS/src/templates/opac/parts/sms_carrier_selector.tt2
+++ b/Open-ILS/src/templates/opac/parts/sms_carrier_selector.tt2
@@ -19,6 +19,7 @@
 %]
 [% IF NOT sms_carrier_hide_label; l('Mobile carrier:'); END; %]
 <select name="sms_carrier">
+    <option value="">[% l('') %]</option>
     [% FOR carrier IN carriers.sort('name','region') -%]
     <option value='[% carrier.id | html %]'[%
         default_carrier == carrier.id ? ' selected="selected"' : ''

-----------------------------------------------------------------------

Summary of changes:
 .../templates/opac/parts/sms_carrier_selector.tt2  |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)


hooks/post-receive
-- 
Evergreen ILS