[open-ils-commits] [GIT] Evergreen ILS branch master updated. 4103ef01a877a025b4c1bd44c5439f1b49e3a70a

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  4103ef01a877a025b4c1bd44c5439f1b49e3a70a (commit)
      from  b17fad6b7a21bf86ef04fa45e000f01a7dc1e809 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 4103ef01a877a025b4c1bd44c5439f1b49e3a70a
Author: Cesar Velez <cesar.velez at equinoxinitiative.org>
Date:   Tue Aug 8 16:13:15 2017 -0400

    LP#1624443 - TPAC 500 error after adding duplicate title to Temp List
    
    Credit to gmcharlt, prevents the my list (temporary list) page from
    crashing when a user has added a title to the list more than once.
    This can happen if they add a title then login, then redo search and
    add same title. Per Galen, it looks like an issue with
    OpenSRF::MultiSession parallel record retrieval causing some kind of
    race condition when there are duplicate entries in the list.
    
    Signed-off by: Cesar Velez <cesar.velez at equinoxinitiative.org>
    Signed-off-by: Chris Sharp <csharp at georgialibraries.org>
    Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Util.pm b/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Util.pm
index 199ff7a..eb268dc 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Util.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Util.pm
@@ -3,6 +3,7 @@ use strict; use warnings;
 use Apache2::Const -compile => qw(OK DECLINED FORBIDDEN HTTP_INTERNAL_SERVER_ERROR REDIRECT HTTP_BAD_REQUEST);
 use File::Spec;
 use Time::HiRes qw/time sleep/;
+use List::MoreUtils qw/uniq/;
 use OpenSRF::Utils::Cache;
 use OpenSRF::Utils::Logger qw/$logger/;
 use OpenILS::Utils::CStoreEditor qw/:funcs/;
@@ -420,7 +421,7 @@ sub get_records_and_facets {
     $self->timelog("get_records_and_facets(): about to call ".
         "$unapi_type via json_query (rec_ids has " . scalar(@$rec_ids));
 
-    my @loop_recs = @$rec_ids;
+    my @loop_recs = uniq @$rec_ids;
     my %rec_timeout;
 
     while (my $bid = shift @loop_recs) {

-----------------------------------------------------------------------

Summary of changes:
 .../perlmods/lib/OpenILS/WWW/EGCatLoader/Util.pm   |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
Evergreen ILS