[open-ils-commits] [GIT] Evergreen ILS branch master updated. 4fc789e90bc31f98cd3adb3898ee2d5e23bca3b8

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  4fc789e90bc31f98cd3adb3898ee2d5e23bca3b8 (commit)
      from  18d1064ed6df5dee42f0987ec71040fc9f5dd7bd (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 4fc789e90bc31f98cd3adb3898ee2d5e23bca3b8
Author: Cesar Velez <cesar.velez at equinoxinitiative.org>
Date:   Wed Aug 16 17:39:30 2017 -0400

    LP#1683575 - Webstaff fix silent fail of bad barcodes in ItemStatus
    
    This address the current issue in master, that causes bad barcodes
    to fail silently.
    
    To test
    -------
    [1] In the web staff client, go to Item Status and enter an item
        barcode that is not present in the database. Note that no
        warning message displayed.
    [2] Apply the patch and repeat step 1. This tie, an 'Item Not Found'
        message is displayed.
    
    Signed-off by: Cesar Velez <cesar.velez at equinoxinitiative.org>
    Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>

diff --git a/Open-ILS/web/js/ui/default/staff/circ/services/item.js b/Open-ILS/web/js/ui/default/staff/circ/services/item.js
index 28eae2a..17d3269 100644
--- a/Open-ILS/web/js/ui/default/staff/circ/services/item.js
+++ b/Open-ILS/web/js/ui/default/staff/circ/services/item.js
@@ -99,7 +99,11 @@ function(egCore , egCirc , $uibModal , $q , $timeout , $window , egConfirmDialog
                     return copyData;
                 });
         }
+
         return fetchCopy(barcode, id).then(function(res) {
+
+            if(!res.copy) { return $q.when(); }
+
             return fetchCirc(copyData.copy).then(function(res) {
                 if (copyData.circ) {
                     return fetchSummary(copyData.circ).then(function() {
@@ -122,6 +126,7 @@ function(egCore , egCirc , $uibModal , $q , $timeout , $window , egConfirmDialog
 
         return service.retrieveCopyData(barcode, id)
         .then(function(copyData) {
+            if(!copyData) { return $q.when(); }
             //Make sure we're getting a completed copyData - no plain acp or circ objects
             if (copyData.circ) {
                 // flesh circ_lib locally

-----------------------------------------------------------------------

Summary of changes:
 .../web/js/ui/default/staff/circ/services/item.js  |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)


hooks/post-receive
-- 
Evergreen ILS