[open-ils-commits] [GIT] Evergreen ILS branch master updated. 82732c5b76ccc8ee9e5a7efc427bab39eaf9d121

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  82732c5b76ccc8ee9e5a7efc427bab39eaf9d121 (commit)
       via  35730098fb539ba6794eaed123de7a534b7f03e2 (commit)
      from  6c537fc3a063cbb2d1c13907b3d94b6fcde09e73 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 82732c5b76ccc8ee9e5a7efc427bab39eaf9d121
Author: Bill Erickson <berickxx at gmail.com>
Date:   Tue Feb 14 10:53:54 2017 -0500

    LP#1662902: do not re-download EDI files that failed parsing
    
    Avoid fetching and creating edi_message entries for EDI messages that
    the system cannot parse.
    
    In the event parsing failed due to a temporary condition (e.g. Ruby
    translator was not running), messages can be reprocessed by either
    deleting the offending edi_message row or setting its status to 'retry'.
    
    See previous commit ("LP#1662902: do not re-download EDI files that
    failed processing") for a more detailed explanation.
    
    Signed-off-by: Bill Erickson <berickxx at gmail.com>
    Signed-off-by: Mike Rylander <mrylander at gmail.com>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Acq/EDI.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Acq/EDI.pm
index 60f7dc2..8676a6b 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Acq/EDI.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Acq/EDI.pm
@@ -136,7 +136,7 @@ sub retrieve_core {
                             in_dir => $account->in_dir
                         },
                         remote_file => {ilike => $remote_file},
-                        status      => {'in' => [qw/ processed proc_error /]},
+                        status      => {'in' => [qw/ processed proc_error trans_error /]},
                     },
                     { join => {"acqedi" => {}}, limit => 1 }
                 ], { idlist => 1 }

commit 35730098fb539ba6794eaed123de7a534b7f03e2
Author: Galen Charlton <gmc at equinoxinitiative.org>
Date:   Thu Feb 9 12:24:35 2017 -0500

    LP#1662902: do not re-download EDI files that failed processing
    
    At present, the EDI fetcher ignores files (as determined by file
    name and EDI account details) that were already successfully
    processed. With this patch, ones that failed processing (e.g.,
    acq.edi_message.state = 'proc_error') previously are ignored
    as well.
    
    This is because most processing errors reflect conditions that
    require some sort of manual intervention on the part of the materials
    vendor or the Evergreen user; having edi_fetcher.pl simply redownload
    and attempt to process the file has no effect other than causing
    the acq.edi_message table to grow.
    
    With this patch, the appearance of rows in acq.edi_message whose
    state is 'proc_error' should be taken as a signal to the Evergreen
    admin to investigate and resolve whatever issue caused the
    message to not be processed; after doing that, removing the
    acq.edi_message rows will allow the file to be downloaded again
    (assuming it's still available on the file server).
    
    To test
    -------
    [1] Arrange to create or simulate an EDI message that failed
        processing.
    [2] Run edi_fetcher.pl to have it attempt to download the
        failed message in step #1; verify that the file is
        /not/ downloaded again and that no additonal acq.edi_message
        rows are created for it.
    
    Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>
    Signed-off-by: Bill Erickson <berickxx at gmail.com>
    Signed-off-by: Mike Rylander <mrylander at gmail.com>

diff --git a/Open-ILS/src/perlmods/lib/OpenILS/Application/Acq/EDI.pm b/Open-ILS/src/perlmods/lib/OpenILS/Application/Acq/EDI.pm
index ee978e2..60f7dc2 100644
--- a/Open-ILS/src/perlmods/lib/OpenILS/Application/Acq/EDI.pm
+++ b/Open-ILS/src/perlmods/lib/OpenILS/Application/Acq/EDI.pm
@@ -136,7 +136,7 @@ sub retrieve_core {
                             in_dir => $account->in_dir
                         },
                         remote_file => {ilike => $remote_file},
-                        status      => {'in' => [qw/ processed /]},
+                        status      => {'in' => [qw/ processed proc_error /]},
                     },
                     { join => {"acqedi" => {}}, limit => 1 }
                 ], { idlist => 1 }

-----------------------------------------------------------------------

Summary of changes:
 .../perlmods/lib/OpenILS/Application/Acq/EDI.pm    |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)


hooks/post-receive
-- 
Evergreen ILS