[open-ils-commits] [GIT] Evergreen ILS branch rel_2_12 updated. d886b1663822f8b636e790db538ffa9618b3b274

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_2_12 has been updated
       via  d886b1663822f8b636e790db538ffa9618b3b274 (commit)
       via  00bdbf1333b6f2e265318ae39d42acf215a0e9a3 (commit)
      from  ff6f7b5b313690f0ba6b243fbfad6df514461f53 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit d886b1663822f8b636e790db538ffa9618b3b274
Author: Galen Charlton <gmc at equinoxinitiative.org>
Date:   Wed Jul 19 11:12:29 2017 -0400

    LP#1669907: add comment about underlying cause of the bug
    
    Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>

diff --git a/Open-ILS/web/js/ui/default/staff/cat/catalog/app.js b/Open-ILS/web/js/ui/default/staff/cat/catalog/app.js
index 27eb25f..c8b4950 100644
--- a/Open-ILS/web/js/ui/default/staff/cat/catalog/app.js
+++ b/Open-ILS/web/js/ui/default/staff/cat/catalog/app.js
@@ -1513,6 +1513,10 @@ function($scope , $routeParams , $location , $window , $q , egCore , egHolds , e
         ).then(
             function(hold_data) {
                 hold_ids = []; // clear the list of ids, hack to avoid dups
+                // TODO: fix the underlying problem, which is that
+                // this gets called twice when switching to the holds
+                // tab; once explicitly, and once via the change handler
+                // on the OU selector
                 angular.forEach(hold_data, function(list, type) {
                     hold_ids = hold_ids.concat(list);
                 });

commit 00bdbf1333b6f2e265318ae39d42acf215a0e9a3
Author: Cesar Velez <cesar.velez at equinoxinitiative.org>
Date:   Mon Jun 26 12:25:06 2017 -0400

    LP#1669907: Web Staff Bib record Holds View dups
    
    In the webstaff client, switching from the View Holds tab
    to the OPAC View and back would result in the list of hold
    requests getting duplicated.
    
    This patch fixes the problem.
    
    Caching of tab data is explicitly not being done ATM,
    so this takes care of the issue for now.
    
    Signed-off-by: Cesar Velez <cesar.velez at equinoxinitiative.org>
    Signed-off-by: Terran McCanna <tmccanna at georgialibraries.org>
    Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>

diff --git a/Open-ILS/web/js/ui/default/staff/cat/catalog/app.js b/Open-ILS/web/js/ui/default/staff/cat/catalog/app.js
index 1f1ac58..27eb25f 100644
--- a/Open-ILS/web/js/ui/default/staff/cat/catalog/app.js
+++ b/Open-ILS/web/js/ui/default/staff/cat/catalog/app.js
@@ -1512,6 +1512,7 @@ function($scope , $routeParams , $location , $window , $q , egCore , egHolds , e
             {pickup_lib : egCore.org.descendants($scope.pickup_ou.id(), true)}
         ).then(
             function(hold_data) {
+                hold_ids = []; // clear the list of ids, hack to avoid dups
                 angular.forEach(hold_data, function(list, type) {
                     hold_ids = hold_ids.concat(list);
                 });

-----------------------------------------------------------------------

Summary of changes:
 .../web/js/ui/default/staff/cat/catalog/app.js     |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)


hooks/post-receive
-- 
Evergreen ILS