[open-ils-commits] [GIT] Evergreen ILS branch master updated. a3a39064f1686bd58b90e2c0af7995ed85468d3a

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, master has been updated
       via  a3a39064f1686bd58b90e2c0af7995ed85468d3a (commit)
      from  416c5540be8921268e33f4267f777887d8b09110 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit a3a39064f1686bd58b90e2c0af7995ed85468d3a
Author: Jason Boyer <jboyer at library.in.gov>
Date:   Fri Jul 7 10:24:35 2017 -0400

    LP1702911: Correct Barcode State in Add Item
    
    When adding an item from the MARC editor the barcode
    state was incorrect because the empty_barcode flag
    is set on the copy and then not changed after
    assigning a barcode. At that point the only way to
    alter the flag is modifying the barcode in the UI,
    which the user likely would not think to do. This
    causes the Save buttons to remain disabled.
    
    To test pre patch:
    Open a record in the MARC editor, check Add Item
    Add a call number label and barcode above, click Save
    In the vol/copy editor, try as you might, you can't save. :(
    
    To test post-patch:
    Open a record in the MARC editor, check Add Item
    Add a call number label and barcode above, click Save
    In the vol/copy editor, the Save buttons will already be enabled
    (barring required stat cats, etc.)
    
    Signed-off-by: Jason Boyer <jboyer at library.in.gov>
    Signed-off-by: Josh Stompro <stomproj at larl.org>
    Signed-off-by: Kathy Lussier <klussier at masslnc.org>

diff --git a/Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js b/Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js
index bbf44a2..fce1e7a 100644
--- a/Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js
+++ b/Open-ILS/web/js/ui/default/staff/cat/volcopy/app.js
@@ -1209,7 +1209,10 @@ function($scope , $q , $window , $routeParams , $location , $timeout , egCore ,
                                         ((!$scope.only_vols) ? true : false)
                                     );
 
-                                    if (proto.barcode) cp.barcode( proto.barcode );
+                                    if (proto.barcode) {
+                                        cp.barcode( proto.barcode );
+                                        cp.empty_barcode = false;
+                                    }
 
                                     itemSvc.addCopy(cp)
                                 });
@@ -1256,7 +1259,10 @@ function($scope , $q , $window , $routeParams , $location , $timeout , egCore ,
                                     true
                                 );
 
-                                if (proto.barcode) cp.barcode( proto.barcode );
+                                if (proto.barcode) {
+                                    cp.barcode( proto.barcode );
+                                    cp.empty_barcode = false;
+                                }
 
                                 itemSvc.addCopy(cp)
                             }

-----------------------------------------------------------------------

Summary of changes:
 .../web/js/ui/default/staff/cat/volcopy/app.js     |   10 ++++++++--
 1 files changed, 8 insertions(+), 2 deletions(-)


hooks/post-receive
-- 
Evergreen ILS