[open-ils-commits] [GIT] Evergreen ILS branch rel_2_12 updated. 471e9cfcbb3e5518216729f47f0f9bb7721ece7b

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Evergreen ILS".

The branch, rel_2_12 has been updated
       via  471e9cfcbb3e5518216729f47f0f9bb7721ece7b (commit)
      from  0875e68e3fba2ec62fca73b00a6ef17f30f6078f (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 471e9cfcbb3e5518216729f47f0f9bb7721ece7b
Author: Josh Stompro <stomproj at larl.org>
Date:   Mon Jul 24 13:51:55 2017 -0500

    LP#1706148 - Hide "Hold is behind Circ Desk" checkbox in XUL patron registration.
    
    When the library setting for "Behind Desk Pickup Supported" is not enabled then
    the checkbox for "Hold is behind Circ Desk" should be hidden.
    
    Test Plan - before fix:
      1. Check to make sure that the "Behind Desk Pickup Supported" library setting is
         unset or false.
      2. Open the patron registration screen in the XUL staff client and see that the
         user settings checkbox for "Hold is behind Circ Desk" exists.
    
    After Fix Applied:
      1. Check to make sure that the "Behind Desk Pickup Supported" library setting is
         unset or false.
      2. Open the patron registration screen in the XUL staff client and see that the
         user settings checkbox for "Hold is behind Circ Desk" no longer is shown.
      3. Change the library setting in question to True.
      4. Reload/reopen the patron registration screen and see that the checkbox now
         is visible.
    
    Signed-off-by: Josh Stompro <stomproj at larl.org>
    Signed-off-by: Dan Pearl <dpearl at cwmars.org>
    Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>

diff --git a/Open-ILS/web/js/ui/default/actor/user/register.js b/Open-ILS/web/js/ui/default/actor/user/register.js
index 8658667..0e9ae91 100644
--- a/Open-ILS/web/js/ui/default/actor/user/register.js
+++ b/Open-ILS/web/js/ui/default/actor/user/register.js
@@ -974,6 +974,13 @@ function uEditDrawSettingRow(tbody, dividerRow, template, stype) {
             tb.attr('value', userSettings[stype.name()]);
             dojo.connect(tb, 'onChange', function(newVal) { userSettingsToUpdate[stype.name()] = newVal; });
             break;
+        case 'circ.holds_behind_desk':
+            // Skip when hold is behind circ desk is not enabled
+            if(!orgSettings['circ.holds.behind_desk_pickup_supported']) return;
+            var cb = new dijit.form.CheckBox({scrollOnFocus:false}, getByName(row, 'widget'));
+            cb.attr('value', userSettings[stype.name()]);
+            dojo.connect(cb, 'onChange', function(newVal) { userSettingsToUpdate[stype.name()] = newVal; });
+            break;
         default:
             var cb = new dijit.form.CheckBox({scrollOnFocus:false}, getByName(row, 'widget'));
             cb.attr('value', userSettings[stype.name()]);

-----------------------------------------------------------------------

Summary of changes:
 Open-ILS/web/js/ui/default/actor/user/register.js |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)


hooks/post-receive
-- 
Evergreen ILS